Fix generated config when binding to IPv6 addresses#227
Merged
TheMeier merged 2 commits intovoxpupuli:masterfrom Oct 18, 2025
Merged
Fix generated config when binding to IPv6 addresses#227TheMeier merged 2 commits intovoxpupuli:masterfrom
TheMeier merged 2 commits intovoxpupuli:masterfrom
Conversation
When using an ipv6 address in the host we need to wrap the addresses win square brackets.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for IPv6 addresses in the HTTP port configuration by wrapping IPv6 addresses in square brackets, following the standard format for IPv6 addresses in URLs and host:port combinations.
- Refactored the host:port string construction logic to use a conditional expression instead of if-else blocks
- Added IPv6 address detection using
Stdlib::IP::Address::V6type checking - IPv6 addresses are now properly wrapped in square brackets when combined with port numbers
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| manifests/http_port.pp | Implements IPv6 address detection and wrapping logic using conditional expression |
| spec/defines/http_port_spec.rb | Adds test case to verify IPv6 addresses are properly wrapped in square brackets |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
smortex
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using an ipv6 address in the host we need to wrap the addresses with square brackets.