Skip to content

Conversation

@TheKrizz
Copy link

only need a ci run on master

ca-certificates-java for debian 11
update-ca-certificates -f for debian 11
@TheKrizz TheKrizz changed the title Update init.pp Fix Debian11 Tests Sep 29, 2025
@TheKrizz
Copy link
Author

added "/usr/sbin/update-ca-certificates" to spec/acceptance/certs_spec.rb

@TheKrizz TheKrizz marked this pull request as ready for review September 29, 2025 10:31
@TheKrizz TheKrizz mentioned this pull request Sep 29, 2025
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this just mask a real issue? The whole point of this module is for the CA to be trusted. If the user needs to manually update the trusted certificates after then it's missing the point.

There is already an exec that is supposed to do this:

exec { 'update_system_certs':
command => $update_command,
path => $path,
logoutput => on_failure,
refreshonly => true,
}

And that is notified here:

notify => Exec['update_system_certs'],

That in turn is notified above:

notify => Exec["validate ${install_path}/${_name}"],

So something appears to be wrong if this workaround is needed.

@TheKrizz
Copy link
Author

Then "exec { 'update_system_certs':" in https://github.com/voxpupuli/puppet-trusted_ca/blob/master/manifests/init.pp#L22-L27 don't work or don't get a notify

Because when i add update-ca-certificates to this spec file and it runs ca-certificates-java, then the used java under usr/bin/java trusts the generated certs or knows about them.

@ekohl
Copy link
Member

ekohl commented Sep 29, 2025

I think the problem is that chained notifications are unreliable. I hope #86 is a reliable fix for it.

@ekohl
Copy link
Member

ekohl commented Sep 29, 2025

I can't figure it out. Perhaps it's time to drop Debian 11 support instead?

@TheKrizz
Copy link
Author

i think on debian11 we need the command "/usr/sbin/update-ca-certificates" or we have to use this exec
https://github.com/voxpupuli/puppet-trusted_ca/blob/master/manifests/java.pp#L58-L64 or we need to set the path of the truststore

https://github.com/rksk/SSLPoke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants