conf_d: merge the unbound_conf_d and conf_d params #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request merges two similar parameters (unbound_conf_d and conf_d) that serve the same purpose of managing unbound configuration directories. The change consolidates functionality by removing the duplicate unbound_conf_d parameter and updating all references to use the unified conf_d parameter instead.
Key changes:
- Removes the
unbound_conf_dparameter and relatedpurge_unbound_conf_dparameter - Updates all code to use
conf_dandpurge_conf_dconsistently - Adds OS-specific logic to set appropriate conf_d directory paths and ownership
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| manifests/init.pp | Removes duplicate parameters and updates file resource to use unified conf_d configuration |
| spec/classes/init_spec.rb | Updates test variables and expectations to use new parameter names and adds OS-specific logic |
| data/os/Debian.yaml | Updates Debian-specific configuration to use new parameter names and sets conf_d path |
| REFERENCE.md | Updates documentation to reflect parameter name changes and removes deprecated parameter |
b4ldr
force-pushed
the
342_conf_d
branch
2 times, most recently
from
c0e1d39 to
b3f49c8
Compare
AFAICT the intention of theses two parameters is the same so lets merge them fixes voxpupuli#342 Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAICT the intention of theses two parameters is the same so lets merge them
fixes #342