Conversation
|
I have tried to solve the failed jobs, but I really don't know, what's there failing. I have just fixed documentation, but there were only warnings: In the step In the step Could you please at least tell me, what's wrong, what should be fixed? Thank you. |
|
I am reading .github/CONTRIBUTING.md now ... |
* update REFERENCE.md * add "@param" to code * rewrite profile code - use profile_param for netsh only if any profile defined * use default "undef" for profile * join only array, otherwise copy single value * add tests
3d032a7 to
bf8e8f6
Compare
|
OK, changes done, tests passed. I hope this is ready to merge. I am going to test it now, I was working, when PR created by @gmiranda. |
just fixed conflicts in PR #96 and added tests (I am neither ruby nor puppet programmer, so I hope the tests are correct).
We would like to have this patch for windows 2025. It looks like windows 2025 creates openssh inbound rule only in "private", but we need the rule in "domain" too. It would be great to merge PR #132 too to be able update the rules (if not already done in some other PR).
Thank you.