Skip to content

Implemented profile selection#159

Merged
yakatz merged 5 commits intovoxpupuli:masterfrom
abacusresearch:gmiranda-profile-patch
May 5, 2025
Merged

Implemented profile selection#159
yakatz merged 5 commits intovoxpupuli:masterfrom
abacusresearch:gmiranda-profile-patch

Conversation

@wolfaba
Copy link
Contributor

@wolfaba wolfaba commented May 5, 2025

just fixed conflicts in PR #96 and added tests (I am neither ruby nor puppet programmer, so I hope the tests are correct).

We would like to have this patch for windows 2025. It looks like windows 2025 creates openssh inbound rule only in "private", but we need the rule in "domain" too. It would be great to merge PR #132 too to be able update the rules (if not already done in some other PR).

Thank you.

@wolfaba wolfaba changed the title Implemented profile selection - Gmiranda profile patch updated - conflict resolved Implemented profile selection - Gmiranda profile patch updated - conflicts resolved, tests added May 5, 2025
@wolfaba
Copy link
Contributor Author

wolfaba commented May 5, 2025

I have tried to solve the failed jobs, but I really don't know, what's there failing. I have just fixed documentation, but there were only warnings:

[warn]: Missing @param tag for parameter 'ensure' near manifests/init.pp:28.
[warn]: Missing @param tag for parameter 'exceptions' near manifests/init.pp:28.
[warn]: Missing @param tag for parameter 'ensure' near manifests/exception.pp:83.
[warn]: Missing @param tag for parameter 'direction' near manifests/exception.pp:83.
[warn]: Missing @param tag for parameter 'action' near manifests/exception.pp:83.
[warn]: Missing @param tag for parameter 'enabled' near manifests/exception.pp:83.
[warn]: Missing @param tag for parameter 'protocol' near manifests/exception.pp:83.
[warn]: Missing @param tag for parameter 'local_port' near manifests/exception.pp:83.
[warn]: Missing @param tag for parameter 'remote_port' near manifests/exception.pp:83.
[warn]: Missing @param tag for parameter 'remote_ip' near manifests/exception.pp:83.
[warn]: Missing @param tag for parameter 'program' near manifests/exception.pp:83.
[warn]: Missing @param tag for parameter 'display_name' near manifests/exception.pp:83.
[warn]: Missing @param tag for parameter 'description' near manifests/exception.pp:83.
[warn]: Missing @param tag for parameter 'allow_edge_traversal' near manifests/exception.pp:83.
[warn]: Missing @param tag for parameter 'profile' near manifests/exception.pp:83.
[warn]: Missing documentation for Puppet type alias 'Windows_firewall::Port' at types/port.pp:1.

In the step Puppet / Static validations there is an error Error: Process completed with exit code 1. and there is only other message REFERENCE.md is outdated; to regenerate: bundle exec rake strings:generate:reference, other messages are Syntax OK.

In the step Puppet / Test suite there is same error Error: Process completed with exit code 1. and other message is # ❌ Some of the required to succeed jobs failed 😢😢😢. I don't see any other error message, which could tell me, what's wrong.

Could you please at least tell me, what's wrong, what should be fixed?

Thank you.

@wolfaba
Copy link
Contributor Author

wolfaba commented May 5, 2025

I am reading .github/CONTRIBUTING.md now ...

* update REFERENCE.md

* add "@param" to code

* rewrite profile code - use profile_param for netsh only if any profile defined

* use default "undef" for profile

* join only array, otherwise copy single value

* add tests
@wolfaba wolfaba force-pushed the gmiranda-profile-patch branch from 3d032a7 to bf8e8f6 Compare May 5, 2025 09:10
@wolfaba
Copy link
Contributor Author

wolfaba commented May 5, 2025

OK, changes done, tests passed.

I hope this is ready to merge.

I am going to test it now, I was working, when PR created by @gmiranda.

@yakatz yakatz merged commit 01e48e2 into voxpupuli:master May 5, 2025
5 checks passed
@yakatz yakatz added the enhancement New feature or request label May 5, 2025
@bastelfreak bastelfreak changed the title Implemented profile selection - Gmiranda profile patch updated - conflicts resolved, tests added Implemented profile selection Dec 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants