Add ability to use http addresses in download_url#51
Open
jcb124 wants to merge 1 commit intovoxpupuli:masterfrom
Open
Add ability to use http addresses in download_url#51jcb124 wants to merge 1 commit intovoxpupuli:masterfrom
jcb124 wants to merge 1 commit intovoxpupuli:masterfrom
Conversation
Modifies the regex used to generate $filename by allowing http and https addresses.
Member
|
Great work @jcb124 ! |
ghoneycutt
requested changes
Aug 25, 2021
Member
ghoneycutt
left a comment
There was a problem hiding this comment.
Could you please add tests that show this working with http and https and failing with an invalid URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies the regex used to generate $filename by allowing http and https addresses. This is a simple fix that doesn't change any logic, but allows the regex to generate the $filename when a http address is used. Previously, using an http address generated the below error:
Fixes #40