Restarting agent if it get's upgraded#875
Open
hertell wants to merge 1 commit intovoxpupuli:masterfrom
Open
Conversation
The agent is not being restarted if the package get's upgraded when using zabbix_package_state => 'latest'. This fix will do that.
evgeni
reviewed
Nov 7, 2023
| ensure => $service_ensure, | ||
| enable => $service_enable, | ||
| require => $service_require, | ||
| subscribe => Package[$zabbix_package_agent], |
Member
There was a problem hiding this comment.
This should already be present via the $service_require, which is defined as:
$service_require = $manage_startup_script ? {
true => [Package[$zabbix_package_agent], Zabbix::Startup[$servicename]],
false => Package[$zabbix_package_agent]
}
If something requires a thing, it will get notified about changes.
Member
There was a problem hiding this comment.
Do you set zabbix_package_state => latest? Otherwise Puppet would not have updated the package and nothing would have issued the notification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
I recently upgraded all agents to the latest 6.4 version of zabbix, and stumbled into Zabbix having issues eg getting old agents not compatible with new items from 6.4. I figured out that the upgrade of the agent-package did upgrade the agent, but it did not restart them, which left the old agent running. This had me to restart all agents manually. This fix will restart the agent if it get's upgraded.