Skip to content

Conversation

@Valantin
Copy link
Contributor

Pull Request (PR) description

Add Ubuntu 24.04 to supported OS

This Pull Request (PR) fixes the following issues

This Pull Request (PR) include

#952

@Valantin Valantin added this to the 10.1.0 milestone Jun 17, 2024
@Valantin Valantin added the enhancement New feature or request label Jun 17, 2024
{
'operatingsystem' => 'Ubuntu',
'operatingsystemrelease' => %w[20.04 22.04]
'operatingsystemrelease' => %w[20.04 22.04 24.04]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in another PR we should remove the whole hash here. It doesn't make sense to duplicate the information from metadata.json. We did that in the past because we only had limited CI power.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but we need to remove not supported os from metadata.json
I'm waiting centos7 EOL to think to release v11

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: With #967 the unit tests will run much faster, so we don't need to worry about the CI runtime for unit tests.

@Valantin Valantin modified the milestones: 10.1.0, 11.0.0 Jun 28, 2024
@baron1405
Copy link

baron1405 commented Aug 19, 2025

If I am reading this conversation correctly, there has been no activity for over a year. Has this module been abandoned on Ubuntu?

@bastelfreak
Copy link
Member

@baron1405 This PR needs to be rebased before we can merge it. If you are interested in it, you can checkout the branch, rebase it against our latest master branch and submit a new PR.

@baron1405
Copy link

@bastelfreak Seems like I would be the least qualified to perform the merge. I have a highly customized puppet environment so developing for the forge environment is something a bit new to me. If you provide instructions on what I should do, I can see if I feel comfortable doing it.

@bastelfreak
Copy link
Member

I don't think you need much Puppet knowledge here. The PR just adds ubuntu 24.04 to two files and those merge conflicts need to be resolved. If you have any git questions you can come to our IRC or slack channel (https://voxpupuli.org/connect/) and we can figure it out together.

@meltingrobot
Copy link

Attempted to create a new MR for this that is updated to the main branch...
#1018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request needs-tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants