Conversation
| { | ||
| 'operatingsystem' => 'Ubuntu', | ||
| 'operatingsystemrelease' => %w[20.04 22.04] | ||
| 'operatingsystemrelease' => %w[20.04 22.04 24.04] |
There was a problem hiding this comment.
I think in another PR we should remove the whole hash here. It doesn't make sense to duplicate the information from metadata.json. We did that in the past because we only had limited CI power.
There was a problem hiding this comment.
yes but we need to remove not supported os from metadata.json
I'm waiting centos7 EOL to think to release v11
There was a problem hiding this comment.
FYI: With #967 the unit tests will run much faster, so we don't need to worry about the CI runtime for unit tests.
|
If I am reading this conversation correctly, there has been no activity for over a year. Has this module been abandoned on Ubuntu? |
|
@baron1405 This PR needs to be rebased before we can merge it. If you are interested in it, you can checkout the branch, rebase it against our latest master branch and submit a new PR. |
|
@bastelfreak Seems like I would be the least qualified to perform the merge. I have a highly customized puppet environment so developing for the forge environment is something a bit new to me. If you provide instructions on what I should do, I can see if I feel comfortable doing it. |
|
I don't think you need much Puppet knowledge here. The PR just adds ubuntu 24.04 to two files and those merge conflicts need to be resolved. If you have any git questions you can come to our IRC or slack channel (https://voxpupuli.org/connect/) and we can figure it out together. |
|
Attempted to create a new MR for this that is updated to the main branch... |
4 participants
Pull Request (PR) description
Add Ubuntu 24.04 to supported OS
This Pull Request (PR) fixes the following issues
This Pull Request (PR) include
#952