Use Hash.to_h to construct a new hash

[ekohl]

Also declares stringify_keys as a private API method.

[bastelfreak]

do you know if that's used somewhere? should we mark it as breaking change? (I want to drop old rubies anyways)

[ekohl]

I think it should only be internal. And marking it with a comment doesn't mean it can't be called anymore, it's only a signal people consuming the API.

[codecov]

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8d9370c) 94.93% compared to head (5e301c3) 94.93%.

❗ Current head 5e301c3 differs from pull request most recent head 59fb9bb. Consider uploading reports for the commit 59fb9bb to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files           2        2           
  Lines         158      158           
=======================================
  Hits          150      150           
  Misses          8        8           

Impacted Files	Coverage Δ
lib/rspec-puppet-facts.rb	98.03% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[ekohl]

Interesting that this behavior is different on Ruby 2.4 & 2.5. I think you finally have a good excuse to drop older versions because I do think this newer version is easier to read.

[bastelfreak]

press the button on #149 :)