Switch from puppet releases to openvox releases #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianrakel
approved these changes
Sep 9, 2025
ekohl
requested changes
Sep 9, 2025
ekohl
requested changes
Sep 9, 2025
binford2k
approved these changes
Sep 9, 2025
bastelfreak
force-pushed
the
db
branch
2 times, most recently
from
bc1f80c to
2628083
Compare
|
@binford2k do you want to have some kind of warning for Puppet AIO users here? Or in facterdb? Do you have anything specific in mind? |
ekohl
reviewed
Sep 10, 2025
ekohl
reviewed
Sep 10, 2025
| end | ||
| end | ||
|
|
||
| def self.facter_version_for_puppet_version(puppet_version) |
There was a problem hiding this comment.
I don't mean to add on all the time, but I'd like to make this consistent and mention OpenVox. How about
Suggested change
| def self.facter_version_for_puppet_version(puppet_version) | |
| def self.openfact_version_for_openvox_version(openvox_version) |
And design wise: I really would appreciate a non-breaking release first (if possible). Then you may want to split out some version finding logic to a helper method.
I considered that. But that will make it hard to distinguish between puppet/openvox factsets. If you want I can just extend the existing json file with our versions. |
bastelfreak
added a commit
to bastelfreak/rspec-puppet-facts
that referenced
this pull request
Sep 18, 2025
Since Perforce stopped building open source AIO packages, we're continuing the list with OpenVox/OpenFact builds. Alternative implementation for voxpupuli#227
bastelfreak
added a commit
to bastelfreak/rspec-puppet-facts
that referenced
this pull request
Sep 18, 2025
Since Perforce stopped building open source AIO packages, we're continuing the list with OpenVox/OpenFact builds. Alternative implementation for voxpupuli#227
bastelfreak
added a commit
to bastelfreak/rspec-puppet-facts
that referenced
this pull request
Sep 18, 2025
Since Perforce stopped building open source AIO packages, we're continuing the list with OpenVox/OpenFact builds. Alternative implementation for voxpupuli#227
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.