Skip to content

Commit 90790fe

Browse files
committed
not allowing to create/update user-level space/event/day entries
1 parent d925720 commit 90790fe

File tree

2 files changed

+23
-23
lines changed

2 files changed

+23
-23
lines changed

cloud/firestore/firestore.default.rules

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -180,20 +180,20 @@ service cloud.firestore {
180180
(this can take a lot of time)
181181
*/
182182
match /tokens-wallet/self {
183-
allow get, create, update, delete: if iAm(userId);
184-
allow list: if false;
183+
allow get, delete: if iAm(userId);
184+
allow list, create, update: if false;
185185
}
186186
match /events/{eventId} {
187-
allow get, list, create, update: if iAm(userId);
188-
allow delete: if false;
187+
allow get, list: if iAm(userId);
188+
allow delete, create, update: if false;
189189

190190
match /talksNotes/{talkId} {
191191
allow get, list, create, update: if iAm(userId);
192192
allow delete: if false;
193193
}
194194
match /days/{dayId} {
195-
allow get, list, create, update: if iAm(userId);
196-
allow delete: if false;
195+
allow get, list: if iAm(userId);
196+
allow delete, create, update: if false;
197197

198198
match /feedbacks/self {
199199
allow get, create, update: if iAm(userId);
@@ -203,20 +203,20 @@ service cloud.firestore {
203203
}
204204

205205
match /spaces/{spaceId} {
206-
allow get, list, create, update: if iAm(userId);
207-
allow delete: if false;
206+
allow get, list: if iAm(userId);
207+
allow delete, create, update: if false;
208208

209209
match /events/{eventId} {
210-
allow get, list, create, update: if iAm(userId);
211-
allow delete: if false;
210+
allow get, list: if iAm(userId);
211+
allow delete, create, update: if false;
212212

213213
match /talksNotes/{talkId} {
214214
allow get, list, create, update: if iAm(userId);
215215
allow delete: if false;
216216
}
217217
match /days/{dayId} {
218-
allow get, list, create, update: if iAm(userId);
219-
allow delete: if false;
218+
allow get, list: if iAm(userId);
219+
allow delete, create, update: if false;
220220

221221
match /feedbacks/self {
222222
allow get, create, update: if iAm(userId);

cloud/firestore/firestore.default.rules.spec.ts

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -792,8 +792,8 @@ const COLLECTIONS: CollectionDescriptor[] = [{
792792
tests: (userContext: UserContext) => {
793793
ensureCollectionFollowAccessPermissions('/users/{userId}/tokens-wallet/self', userContext,
794794
{
795-
get: userContext.name === 'fred user', update: userContext.name === 'fred user',
796-
createDoc: userContext.name === 'fred user', delete: userContext.name === 'fred user',
795+
get: userContext.name === 'fred user', update: false,
796+
createDoc: false, delete: userContext.name === 'fred user',
797797
list: false, createNew: false,
798798
}, 'fred')
799799

@@ -841,9 +841,9 @@ const COLLECTIONS: CollectionDescriptor[] = [{
841841
tests: (userContext: UserContext) => {
842842
ensureCollectionFollowAccessPermissions('/users/{userId}/spaces/{spaceId}', userContext,
843843
{
844-
get: userContext.name === 'fred user', update: userContext.name === 'fred user',
845-
createDoc: userContext.name === 'fred user',
846-
list: userContext.name === 'fred user', delete: false, createNew: userContext.name === 'fred user',
844+
get: userContext.name === 'fred user', update: false,
845+
createDoc: false,
846+
list: userContext.name === 'fred user', delete: false, createNew: false,
847847
}, 'fred')
848848

849849
ensureCollectionFollowAccessPermissions('/users/{userId}/spaces/{spaceId}', userContext,
@@ -868,9 +868,9 @@ const COLLECTIONS: CollectionDescriptor[] = [{
868868
ensureCollectionFollowAccessPermissions(`/users/{userId}/${eventFirestorePath(space.id)}`, userContext,
869869
{
870870
delete: false,
871-
get: userContext.name === 'fred user', update: userContext.name === 'fred user',
872-
list: userContext.name === 'fred user', createDoc: userContext.name === 'fred user',
873-
createNew: userContext.name === 'fred user',
871+
get: userContext.name === 'fred user', update: false,
872+
list: userContext.name === 'fred user', createDoc: false,
873+
createNew: false,
874874
}, 'fred')
875875

876876
ensureCollectionFollowAccessPermissions(`/users/{userId}/${eventFirestorePath(space.id)}`, userContext,
@@ -924,9 +924,9 @@ const COLLECTIONS: CollectionDescriptor[] = [{
924924
ensureCollectionFollowAccessPermissions(`/users/{userId}/${eventFirestorePath(space.id)}/days/{dayId}`, userContext,
925925
{
926926
delete: false,
927-
get: userContext.name === 'fred user', update: userContext.name === 'fred user',
928-
list: userContext.name === 'fred user', createDoc: userContext.name === 'fred user',
929-
createNew: userContext.name === 'fred user',
927+
get: userContext.name === 'fred user', update: false,
928+
list: userContext.name === 'fred user', createDoc: false,
929+
createNew: false,
930930
}, 'fred')
931931

932932
ensureCollectionFollowAccessPermissions(`/users/{userId}/${eventFirestorePath(space.id)}/days/{dayId}`, userContext,

0 commit comments

Comments
 (0)