chore: migrate ignore files and update CI trigger#24
Conversation
- Rename .prettierignore to .eslintignore for ESLint ignore patterns - Add ignore patterns to .oxfmtrc.json for oxfmt formatter - Update VSCode workspace to recommend oxc extension instead of prettier - Update README example to use .eslintignore Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary of ChangesHello @VdustR, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the project's code quality tooling by migrating from Prettier to Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively migrates the project from using .prettierignore to .eslintignore for ESLint and adds ignore patterns to .oxfmtrc.json for the oxfmt formatter. The changes are consistent across the codebase, including updates to the VSCode workspace settings, README documentation, and other configuration files. I have one suggestion regarding the duplication of ignore patterns to improve long-term maintainability.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary
.prettierignoreto.eslintignorefor ESLint ignore patterns.oxfmtrc.jsonfor oxfmt formatteroxc.oxc-vscodeextension instead ofprettier.prettier-vscode.eslintignoremainbranch (PR checks still run on all PRs)Test plan
pnpm run lint:es:dry- ESLint passespnpm run lint:oxfmt:dry- oxfmt formatting passespnpm run checkTypes- Type checking passes🤖 Generated with Claude Code