Skip to content

chore: migrate ignore files and update CI trigger#24

Merged
VdustR merged 2 commits intomainfrom
chore/migrate-prettierignore-to-oxfmt
Jan 28, 2026
Merged

chore: migrate ignore files and update CI trigger#24
VdustR merged 2 commits intomainfrom
chore/migrate-prettierignore-to-oxfmt

Conversation

@VdustR
Copy link
Collaborator

@VdustR VdustR commented Jan 28, 2026

Summary

  • Rename .prettierignore to .eslintignore for ESLint ignore patterns
  • Add ignore patterns to .oxfmtrc.json for oxfmt formatter
  • Update VSCode workspace to recommend oxc.oxc-vscode extension instead of prettier.prettier-vscode
  • Update README example to use .eslintignore
  • CI: Only run check workflow on push to main branch (PR checks still run on all PRs)

Test plan

  • pnpm run lint:es:dry - ESLint passes
  • pnpm run lint:oxfmt:dry - oxfmt formatting passes
  • pnpm run checkTypes - Type checking passes

🤖 Generated with Claude Code

- Rename .prettierignore to .eslintignore for ESLint ignore patterns
- Add ignore patterns to .oxfmtrc.json for oxfmt formatter
- Update VSCode workspace to recommend oxc extension instead of prettier
- Update README example to use .eslintignore

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@gemini-code-assist
Copy link

Summary of Changes

Hello @VdustR, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the project's code quality tooling by migrating from Prettier to oxfmt and consolidating ignore patterns under ESLint. The changes involve renaming the primary ignore file, configuring the new formatter with appropriate exclusions, and updating development environment recommendations to reflect this transition. The overall impact is a more consistent and modern approach to linting and formatting across the codebase.

Highlights

  • Configuration File Renaming: The .prettierignore file has been renamed to .eslintignore to centralize ignore patterns for ESLint.
  • New Formatter Integration: Ignore patterns have been added to .oxfmtrc.json to configure the oxfmt formatter, indicating a shift in the project's formatting tool.
  • VSCode Extension Recommendation Update: The VSCode workspace configuration has been updated to recommend oxc.oxc-vscode instead of prettier.prettier-vscode, aligning with the new formatting tool.
  • Codebase References Updated: References to the ignore file in README.md and eslint.config.ts have been updated to point to the new .eslintignore.
  • Spell Checker Configuration: The cspell.json file has been updated to include .eslintignore in its ignore list and remove the old .prettierignore.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively migrates the project from using .prettierignore to .eslintignore for ESLint and adds ignore patterns to .oxfmtrc.json for the oxfmt formatter. The changes are consistent across the codebase, including updates to the VSCode workspace settings, README documentation, and other configuration files. I have one suggestion regarding the duplication of ignore patterns to improve long-term maintainability.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@VdustR VdustR changed the title chore: migrate .prettierignore to .eslintignore and .oxfmtrc.json chore: migrate ignore files and update CI trigger Jan 28, 2026
@VdustR VdustR merged commit bc6826c into main Jan 28, 2026
4 checks passed
@VdustR VdustR deleted the chore/migrate-prettierignore-to-oxfmt branch January 28, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant