Skip to content

fix: add explicit type annotation to extendsConfig#26

Merged
VdustR merged 1 commit intomainfrom
fix/build-type-annotation
Jan 28, 2026
Merged

fix: add explicit type annotation to extendsConfig#26
VdustR merged 1 commit intomainfrom
fix/build-type-annotation

Conversation

@VdustR
Copy link
Collaborator

@VdustR VdustR commented Jan 28, 2026

Summary

  • Add explicit return type : void to extendsConfigInternal
  • Add explicit type annotation to extendsConfig constant
  • Resolves TS2742 build error where TypeScript couldn't name the inferred type without referencing the internal @eslint/core module path

Test plan

  • pnpm -F eslint-config build passes without warnings

🤖 Generated with Claude Code

Add explicit return type `: void` to `extendsConfigInternal` and
explicit type annotation to `extendsConfig` to resolve TS2742 build
error where TypeScript couldn't name the inferred type without
referencing the internal @eslint/core module path.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@gemini-code-assist
Copy link

Summary of Changes

Hello @VdustR, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a TypeScript build error by introducing explicit type annotations to key functions and constants within the eslint-config package. The changes aim to improve type inference and prevent issues related to internal module path references, ensuring a cleaner and more robust build process.

Highlights

  • Type Annotation for extendsConfigInternal: An explicit : void return type has been added to the extendsConfigInternal function to clarify its behavior.
  • Explicit Type for extendsConfig Constant: The extendsConfig constant now has an explicit type annotation, which is an intersection of typeof extendsConfigInternal and an object type defining its additional properties (getConfigIndex, tryGetConfigIndex, pushOverations).
  • Build Error Resolution: These type annotations resolve a TS2742 build error where TypeScript was unable to infer the type without referencing an internal @eslint/core module path.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request fixes a TypeScript build error (TS2742) by adding an explicit type annotation to the extendsConfig variable in packages/eslint-config/src/utils/extendsConfig.ts. Additionally, a return type annotation of void was added to the extendsConfigInternal function.

@VdustR VdustR merged commit 421cfbe into main Jan 28, 2026
4 checks passed
@VdustR VdustR deleted the fix/build-type-annotation branch January 28, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant