fix: lazy load @eslint-react/eslint-plugin when react is disabled#29
fix: lazy load @eslint-react/eslint-plugin when react is disabled#29
Conversation
Summary of ChangesHello @VdustR, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a performance optimization by implementing lazy loading for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
0a471bf to
ac8a21b
Compare
There was a problem hiding this comment.
Code Review
This pull request correctly implements lazy loading for @eslint-react/eslint-plugin to avoid loading it when React support is disabled. The changes are logical and well-implemented by introducing a dynamic import wrapper and conditionally calling the React configuration function. I have one suggestion to simplify the dynamic import wrapper for better readability and conciseness.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary
@eslint-react/eslint-pluginwhenreact: false(default)lib/eslint-react.tsfor dynamic importextendsConfigreactEnabledcheck before callingreact()Test plan
🤖 Generated with Claude Code