Skip to content

fix: lazy load @eslint-react/eslint-plugin when react is disabled#29

Merged
VdustR merged 2 commits intomainfrom
fix/lazy-load-react-plugin
Feb 4, 2026
Merged

fix: lazy load @eslint-react/eslint-plugin when react is disabled#29
VdustR merged 2 commits intomainfrom
fix/lazy-load-react-plugin

Conversation

@VdustR
Copy link
Collaborator

@VdustR VdustR commented Feb 4, 2026

Summary

  • Avoid loading @eslint-react/eslint-plugin when react: false (default)
  • Create lib/eslint-react.ts for dynamic import
  • Move static import to async callback in extendsConfig
  • Add reactEnabled check before calling react()

Test plan

  • Type check passes
  • Tests pass
  • Lint passes

🤖 Generated with Claude Code

@gemini-code-assist
Copy link

Summary of Changes

Hello @VdustR, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a performance optimization by implementing lazy loading for the @eslint-react/eslint-plugin. Previously, this plugin would be loaded regardless of whether React linting was enabled. With these changes, the plugin is now dynamically imported only when the React configuration is explicitly activated, leading to reduced startup times and resource consumption for projects that do not utilize React.

Highlights

  • Lazy Loading Implementation: Implemented lazy loading for @eslint-react/eslint-plugin to prevent its loading when React linting is disabled, optimizing resource usage.
  • New Utility File: Introduced a new utility file (lib/eslint-react.ts) to encapsulate the dynamic import logic for the React ESLint plugin.
  • Asynchronous Plugin Import: Refactored the react.ts configuration to use an asynchronous import for the plugin within the extendsConfig callback, leveraging the new utility.
  • Conditional React Configuration: Added a conditional check (reactEnabled) in vdustr.ts to ensure React-specific ESLint configurations are only applied when React is explicitly enabled.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .changeset/lazy-load-react.md
    • Added a new changeset file to document the lazy loading of @eslint-react/eslint-plugin.
  • packages/eslint-config/src/extends/react.ts
    • Removed the direct static import of @eslint-react/eslint-plugin.
    • Updated the extendsConfig callback to asynchronously import the plugin using the new importEslintReact utility.
  • packages/eslint-config/src/lib/eslint-react.ts
    • Created a new file to provide an asynchronous function (eslintReact) for dynamically importing @eslint-react/eslint-plugin using interopDefault.
  • packages/eslint-config/src/vdustr.ts
    • Introduced a reactEnabled boolean flag to determine if React configurations should be applied.
    • Wrapped the call to the react() configuration function within a conditional block based on the reactEnabled flag.
Activity
  • The pull request has passed type checks.
  • All tests are passing.
  • Linting checks have passed.
  • The changes were generated with Claude Code.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@VdustR VdustR force-pushed the fix/lazy-load-react-plugin branch from 0a471bf to ac8a21b Compare February 4, 2026 04:52
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly implements lazy loading for @eslint-react/eslint-plugin to avoid loading it when React support is disabled. The changes are logical and well-implemented by introducing a dynamic import wrapper and conditionally calling the React configuration function. I have one suggestion to simplify the dynamic import wrapper for better readability and conciseness.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@VdustR VdustR merged commit 68031c4 into main Feb 4, 2026
4 checks passed
@VdustR VdustR deleted the fix/lazy-load-react-plugin branch February 4, 2026 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant