Skip to content

fix: add type annotation for eslintReact#31

Merged
VdustR merged 1 commit intomainfrom
fix/eslint-react-type
Feb 4, 2026
Merged

fix: add type annotation for eslintReact#31
VdustR merged 1 commit intomainfrom
fix/eslint-react-type

Conversation

@VdustR
Copy link
Collaborator

@VdustR VdustR commented Feb 4, 2026

Summary

  • Fix TS2742 build error by adding explicit return type annotation

Test plan

  • pnpm build passes

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@VdustR VdustR merged commit eddf769 into main Feb 4, 2026
@VdustR VdustR deleted the fix/eslint-react-type branch February 4, 2026 04:58
@gemini-code-assist
Copy link

Summary of Changes

Hello @VdustR, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a TypeScript build error by introducing a precise type annotation for the eslintReact function. This change ensures the project compiles without TS2742 errors, improving the overall stability and type safety of the codebase.

Highlights

  • Build Error Fix: Resolved a TS2742 build error that was preventing successful compilation.
  • Type Annotation: Added an explicit return type annotation to the eslintReact function to satisfy TypeScript's type checking.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • packages/eslint-config/src/lib/eslint-react.ts
    • Added an import for the EslintReact type.
    • Annotated the eslintReact function with an explicit return type of Promise<typeof EslintReact>.
Activity
  • The pull request was authored by VdustR.
  • A summary of the changes and a test plan were provided by the author.
  • The author confirmed that pnpm build passes after the changes.
  • The pull request was generated with Claude Code.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly identifies the need for an explicit type annotation on the eslintReact function to resolve a build error. The approach is sound, however, there appears to be a minor issue in the type annotation itself. The use of typeof with a type imported via import type is incorrect and should be corrected. With that small change, this PR will be good to go.

import { interopDefault } from "@antfu/eslint-config";

const eslintReact = () => interopDefault(import("@eslint-react/eslint-plugin"));
const eslintReact = (): Promise<typeof EslintReact> =>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The use of typeof here seems incorrect. EslintReact is imported as a type via import type, which means it's not a value and cannot be used with the typeof operator. This should lead to a TypeScript compilation error (TS2693).

The correct type annotation to fix the original build error (TS2742) should just be Promise<EslintReact>, since EslintReact is the named type for the default export.

Suggested change
const eslintReact = (): Promise<typeof EslintReact> =>
const eslintReact = (): Promise<EslintReact> =>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant