Skip to content

fix: add --no-error-on-unmatched-pattern to oxfmt commands#34

Merged
VdustR merged 1 commit intomainfrom
fix/oxfmt-unmatched-pattern
Feb 4, 2026
Merged

fix: add --no-error-on-unmatched-pattern to oxfmt commands#34
VdustR merged 1 commit intomainfrom
fix/oxfmt-unmatched-pattern

Conversation

@VdustR
Copy link
Collaborator

@VdustR VdustR commented Feb 4, 2026

Summary

  • Add --no-error-on-unmatched-pattern flag to oxfmt commands in package.json and lint-staged.config.js
  • Prevents oxfmt from erroring when no matching files are found during linting operations

Test plan

  • Pre-commit hooks pass (verified during commit)
  • Type checking passes
  • Tests pass

🤖 Generated with Claude Code

Prevents oxfmt from erroring when no matching files are found during
linting and lint-staged operations.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@gemini-code-assist
Copy link

Summary of Changes

Hello @VdustR, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the project's linting and formatting pipeline by preventing oxfmt from throwing an error when no files are found to process. By incorporating a specific flag into the oxfmt commands, the system can now gracefully handle scenarios where no matching files exist, ensuring that automated checks continue without unnecessary interruptions.

Highlights

  • oxfmt Configuration Update: The --no-error-on-unmatched-pattern flag has been added to all oxfmt commands within package.json scripts and lint-staged.config.js.
  • Improved Linting Robustness: This change prevents oxfmt from failing and exiting with an error when it does not find any files matching its patterns during linting operations, making the process more resilient.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • lint-staged.config.js
    • Added --no-error-on-unmatched-pattern to the oxfmt --write command within the lint-staged configuration to prevent errors when no files are matched.
  • package.json
    • Modified the lint:oxfmt script to include --no-error-on-unmatched-pattern in the oxfmt --write command.
    • Modified the lint:oxfmt:dry script to include --no-error-on-unmatched-pattern in the oxfmt --check command.
Activity
  • The pull request was authored by VdustR.
  • The author has verified that pre-commit hooks pass, type checking passes, and tests pass.
  • This pull request was generated with Claude Code.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the --no-error-on-unmatched-pattern flag to oxfmt commands in package.json and lint-staged.config.js. This is a good improvement that prevents the formatter from erroring when no matching files are found, making the linting process more robust, especially for pre-commit hooks. The changes are correct and consistently applied across all oxfmt script definitions.

@VdustR VdustR merged commit ef2b2b0 into main Feb 4, 2026
4 checks passed
@VdustR VdustR deleted the fix/oxfmt-unmatched-pattern branch February 4, 2026 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant