Skip to content

Create toggle ai features#859

Merged
HaluBoi merged 2 commits intoNPC-Prefab-Improvementsfrom
create-toggle-ai-features
May 1, 2025
Merged

Create toggle ai features#859
HaluBoi merged 2 commits intoNPC-Prefab-Improvementsfrom
create-toggle-ai-features

Conversation

@selinyo
Copy link

@selinyo selinyo commented May 1, 2025

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Adds AI toggling feature. A new NPC in the receptionOutdoor spawn point was added, who will ask the user about consenting to AI features.

  • What is the current behavior? (You can also link to an open issue here)
    There was no feature to toggle on and off AI features.

  • What is the new behavior? (if this is a feature change)
    Adds AI toggling feature. Currently works only for ReceptionistRachel and Laboratory Guide Larry in Laboratory Scene.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    Made the method "LoadSceneWithLoadingScreen" in AISceneController.cs public. Added an extra condition under in method SpawnNPC in NPCSpawner.cs.

  • Other information:

selinyo and others added 2 commits April 29, 2025 11:23
Add an NPC in receptionOutdoor that will provide AI feature toggling. Reload current active scene when the user has made a choice.

Co-Authored-By: Halvor Heien Førde <halvohf@stud.ntnu.no>
Add an NPC at the ReceptionOutdoor Spawn point that will ask the user about consenting to AI features. Add loading scene when toggling AI features on and off. Make method LoadSceneWithLoadingScreen public so that it can be accessed in ConsentForm.cs. Add a condition in method SpawnNPC in NPCSpawner.cs to listen to toggling state.
@selinyo selinyo requested review from HaluBoi and peter-olai May 1, 2025 14:05
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll remove the commented out code in the OnDestroy function in post

Copy link

@HaluBoi HaluBoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, gang💯

@HaluBoi HaluBoi merged commit af2b897 into NPC-Prefab-Improvements May 1, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants