Open
Conversation
add `doc_type="_doc"` to delete method
Owner
|
Humm change the parameters' order may lead to broken builds by anyone using this method. Do you think that this change still worth? If yes, wdyt of create a new method that already uses the default value? |
Author
|
Wondering maybe creating a |
Owner
|
Humm, good point. Do you still think that we should merge it even knowing that this is a breaking change? Maybe we can do it but add a warning on the Readme and bumping the Major Version. Wdyt? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add
doc_type="_doc"to delete method