-
Notifications
You must be signed in to change notification settings - Fork 8
Add DOLFIN-20230817 easyconfigs #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: site-kul
Are you sure you want to change the base?
Conversation
MaximeVdB
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Steven -- looks good!
Regarding this:
One thing I am not sure about yet is how to deal with the customization of the dolfin.py easyblock. I included it here, but this will become problematic in case we need multiple customized dolfin.py easyblocks.
The only difference with the 'upstream' easyblock is the removal of the Trilinos dependency check, right? If so, maybe the best would be to e.g. add a with_trilinos easyconfig parameter to control whether the dependency check is kept (True by default, and then setting it to False in the present easyconfig).
That is indeed a good approach. The remaining question is how to make sure that the custom easyblock is used when doing the installation. I'll ask for advice in the meeting. |
if you create a PR upstream, you can use EB option |
My question is rather the following: how can I make sure that if someone else tries to repeat the installation, they will not forget to provide the custom easyblock (for instance with |
|
in that case i would suggest to:
we can indeed further discuss in the next meeting |
Geert Buckinx requested a new DOLFIN installation which has some bugfixes compared to
2019.1.0.post0-foss-2021a-Python-3.9.5-SuperLU_DIST, but is otherwise installed in the same way. The version he refers to is2019.2.0.dev0, but unfortunately there is no release with that name and there are multiple commits that share that version name. So I tried to select a set of recent commits from the different fenics components that are compatible with each other, and the result is in this PR.One thing I am not sure about yet is how to deal with the customization of the
dolfin.pyeasyblock. I included it here, but this will become problematic in case we need multiple customizeddolfin.pyeasyblocks.