Skip to content

Conversation

@stevenvdb
Copy link
Collaborator

Geert Buckinx requested a new DOLFIN installation which has some bugfixes compared to 2019.1.0.post0-foss-2021a-Python-3.9.5-SuperLU_DIST, but is otherwise installed in the same way. The version he refers to is 2019.2.0.dev0, but unfortunately there is no release with that name and there are multiple commits that share that version name. So I tried to select a set of recent commits from the different fenics components that are compatible with each other, and the result is in this PR.

One thing I am not sure about yet is how to deal with the customization of the dolfin.py easyblock. I included it here, but this will become problematic in case we need multiple customized dolfin.py easyblocks.

@stevenvdb stevenvdb requested a review from MaximeVdB August 18, 2023 10:17
Copy link
Collaborator

@MaximeVdB MaximeVdB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Steven -- looks good!

Regarding this:

One thing I am not sure about yet is how to deal with the customization of the dolfin.py easyblock. I included it here, but this will become problematic in case we need multiple customized dolfin.py easyblocks.

The only difference with the 'upstream' easyblock is the removal of the Trilinos dependency check, right? If so, maybe the best would be to e.g. add a with_trilinos easyconfig parameter to control whether the dependency check is kept (True by default, and then setting it to False in the present easyconfig).

@stevenvdb
Copy link
Collaborator Author

The only difference with the 'upstream' easyblock is the removal of the Trilinos dependency check, right? If so, maybe the best would be to e.g. add a with_trilinos easyconfig parameter to control whether the dependency check is kept (True by default, and then setting it to False in the present easyconfig).

That is indeed a good approach. The remaining question is how to make sure that the custom easyblock is used when doing the installation. I'll ask for advice in the meeting.

@smoors
Copy link
Collaborator

smoors commented Sep 13, 2023

The only difference with the 'upstream' easyblock is the removal of the Trilinos dependency check, right? If so, maybe the best would be to e.g. add a with_trilinos easyconfig parameter to control whether the dependency check is kept (True by default, and then setting it to False in the present easyconfig).

That is indeed a good approach. The remaining question is how to make sure that the custom easyblock is used when doing the installation. I'll ask for advice in the meeting.

if you create a PR upstream, you can use EB option --include-easyblocks-from-pr <PR>.
alternatively, you can use a local easyblock with --include-easyblocks <path-to-easyblock>

@stevenvdb
Copy link
Collaborator Author

if you create a PR upstream, you can use EB option --include-easyblocks-from-pr <PR>. alternatively, you can use a local easyblock with --include-easyblocks <path-to-easyblock>

My question is rather the following: how can I make sure that if someone else tries to repeat the installation, they will not forget to provide the custom easyblock (for instance with --include-easyblocks)? Is this something that can be done with hooks? Or would you for instance use a custom name for the easyblock? Perhaps we can discuss this in the next meeting.

@smoors
Copy link
Collaborator

smoors commented Sep 13, 2023

in that case i would suggest to:

  1. get the optional parameter with_trilinos (suggested by @MaximeVdB) included in the upstream easyblock
  2. set with_trilinos to false
    2a) either in a hook
    3b) or in a custom easyconfig making sure the custom easyconfig is used by prepending the directory with custom easyconfigs to the robot-paths in your EB configuration file (or with EASYBUID_ROBOT_PATHS)

we can indeed further discuss in the next meeting

@boegel boegel added the site:kul Software installation request for KUL Tier-2 label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

site:kul Software installation request for KUL Tier-2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants