Skip to content

Fix index out of bounds exception for HTML tables #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix index out of bounds exception for HTML tables #652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2750ff6
add test for HTML table with colspan 0
mbrackeantidot May 5, 2025
d9eda5d
avoid counting table column with span 0 as 0 columns
mbrackeantidot May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions flexmark-html2md-converter/src/test/resources/flexmark_html_converter_spec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3010,6 +3010,44 @@ tables with row span cells
````````````````````````````````


table where some rows end with colspan 0

```````````````````````````````` example Tables: 51
| Abc | Def |
|---------|-----|
| no span | span

.
<table>
<thead>
<tr><th>Abc</th><th colspan="1">Def</th></tr>
</thead>
<tbody>
<tr><td>no span</td><td colspan="0">span</td></tr>
</tbody>
</table>
````````````````````````````````


table where all rows end with colspan 0

```````````````````````````````` example Tables: 52
| Abc | Def
|---------|-----|
| no span | span

.
<table>
<thead>
<tr><th>Abc</th><th colspan="0">Def</th></tr>
</thead>
<tbody>
<tr><td>no span</td><td colspan="0">span</td></tr>
</tbody>
</table>
````````````````````````````````


## Definition Lists

a definition in a block quote
Expand Down
3 changes: 2 additions & 1 deletion flexmark-util-format/src/main/java/com/vladsch/flexmark/util/format/TableRow.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import java.util.List;

import static com.vladsch.flexmark.util.format.TableCellManipulator.BREAK;
import static com.vladsch.flexmark.util.misc.Utils.max;
import static com.vladsch.flexmark.util.misc.Utils.maxLimit;
import static com.vladsch.flexmark.util.misc.Utils.minLimit;

Expand Down Expand Up @@ -97,7 +98,7 @@ public int getSpannedColumns() {
int columns = 0;
for (TableCell cell : cells) {
if (cell == null) continue;
columns += cell.columnSpan;
columns += max(cell.columnSpan, 1);
}
return columns;
}
Expand Down