Skip to content

Conversation

Tatsinnit
Copy link
Collaborator

@Tatsinnit Tatsinnit commented Feb 17, 2025

❤️ This PR is to fix #1421 dependabot fix which breaks the build - I need to upload VSIX for quick test, since it's a major version change it comes with few types change within the package. fyi @hsubramanianaks , @ReinierCC + @tejhan cc: @squillace

Opening this for reference for now, will add vsix soon.

Thanks.

@Tatsinnit Tatsinnit self-assigned this Feb 17, 2025
@Tatsinnit Tatsinnit added enhancement dependencies Pull requests that update a dependency file labels Feb 17, 2025
@Tatsinnit Tatsinnit force-pushed the fix-client-code-update branch from c2c2d9d to 2de6c92 Compare February 17, 2025 08:18
@Tatsinnit
Copy link
Collaborator Author

❤️ for fellow readers only , for the version 1.0 the issue is ESM only support and here are few threads worth to understand and I guess work is already in PR to support both now.

thanks!

@ReinierCC ReinierCC force-pushed the fix-client-code-update branch 9 times, most recently from ef968da to dedec82 Compare March 19, 2025 20:25
Signed-off-by: Reinier Cruz <[email protected]>
@Tatsinnit Tatsinnit merged commit e2c25fe into vscode-kubernetes-tools:master Mar 19, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants