Skip to content

Use renderArea instead of full window when compiling RenderGraph #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
theodoregoetz wants to merge 2 commits into from
Closed

Use renderArea instead of full window when compiling RenderGraph #1331

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dab6d2
Use renderArea instead of full window when compiling RenderGraph
john-tecplot Nov 18, 2024
097fef6
Fixed handling of viewport state when the scissor and viewport are di…
Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/vsg/app/CompileTraversal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,14 +387,13 @@ void CompileTraversal::apply(RenderGraph& renderGraph)
auto previousOverridePipelineStates = context->overridePipelineStates;

context->renderPass = renderGraph.getRenderPass();
if (renderGraph.window)
auto const& ra = renderGraph.renderArea;
auto viewportState = ViewportState::create(ra.offset.x, ra.offset.y, ra.extent.width, ra.extent.height);
if (auto view{context->view.ref_ptr()}; view && view->camera)
{
mergeGraphicsPipelineStates(context->mask, context->defaultPipelineStates, ViewportState::create(renderGraph.window->extent2D()));
}
else if (renderGraph.framebuffer)
{
mergeGraphicsPipelineStates(context->mask, context->defaultPipelineStates, ViewportState::create(renderGraph.framebuffer->extent2D()));
viewportState->viewports[0] = view->camera->viewportState->viewports[0];
}
mergeGraphicsPipelineStates(context->mask, context->defaultPipelineStates, viewportState);

if (context->renderPass)
{
Expand All @@ -421,11 +420,13 @@ void CompileTraversal::apply(View& view)
if (context_view && context_view.get() != &view) continue;

// save previous states
auto previous_view = context->view;
auto previous_viewID = context->viewID;
auto previous_mask = context->mask;
auto previous_overridePipelineStates = context->overridePipelineStates;
auto previous_defaultPipelineStates = context->defaultPipelineStates;

context->view = &view;
context->viewID = view.viewID;
context->mask = view.mask;
context->viewDependentState = view.viewDependentState.get();
Expand All @@ -442,6 +443,7 @@ void CompileTraversal::apply(View& view)
view.traverse(*this);

// restore previous states
context->view = previous_view;
context->viewID = previous_viewID;
context->mask = previous_mask;
context->defaultPipelineStates = previous_defaultPipelineStates;
Expand Down
Loading