Fix that vsgimgui changes keyBase to keyModified in keyboard's events#75
Open
ArepMM wants to merge 1 commit intovsg-dev:masterfrom
Open
Fix that vsgimgui changes keyBase to keyModified in keyboard's events#75ArepMM wants to merge 1 commit intovsg-dev:masterfrom
ArepMM wants to merge 1 commit intovsg-dev:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vsgImGui/src/vsgImGui/SendEventsToImGui.cpp contains follow code, which change keyBase value of keyboard's events.
In apply(vsg::KeyPressEvent& keyPress):
...
if (keyPress.keyModified >= vsg::KEY_KP_0 && keyPress.keyModified <= vsg::KEY_KP_9) keyPress.keyBase = keyPress.keyModified;
...
and the same in SendEventsToImGui::apply(vsg::KeyReleaseEvent& keyRelease):
...
if (keyRelease.keyModified >= vsg::KEY_KP_0 && keyRelease.keyModified <= vsg::KEY_KP_9) keyRelease.keyBase = keyRelease.keyModified;
...
In Windows with cyrilic keyboard layout we found a problem: when we press shift + 3, it is symbol "№" and keyModified for it is 0xFFB9. It is the same as value of vsg::KEY_KP_9. So this code is run and we get keyBase = vsg::KEY_KP_9 instead of keyBase = vsg::KEY_3 for all event handlers after vsgImGui. I fix the problem with simple rewriting, which save keyBase changeless.