Skip to content

Add ADR for Function Revisions#133

Merged
Kidswiss merged 3 commits intomasterfrom
adr/functionrevisions
Feb 26, 2025
Merged

Add ADR for Function Revisions#133
Kidswiss merged 3 commits intomasterfrom
adr/functionrevisions

Conversation

@Kidswiss
Copy link
Contributor

@Kidswiss Kidswiss commented Jan 30, 2025

Summary

Checklist

  • Try to isolate changes into separate PRs (to build a better changelog).
  • Categorize the PR by setting a good title and adding one of the labels:
    change, decision, requirement/quality, requirement/functional, dependency
    as they show up in the changelog
  • Link this PR to related issues if applicable.

@Kidswiss Kidswiss added the decision A decision that changes the architecture label Jan 30, 2025
@Kidswiss Kidswiss requested review from a team, TheBigLee, tobru, wejdross and zugao and removed request for a team January 30, 2025 08:16
Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some points to discuss

@Kidswiss Kidswiss force-pushed the adr/functionrevisions branch from c143a79 to aa4c08a Compare January 30, 2025 14:55
@Kidswiss Kidswiss requested a review from zugao January 30, 2025 14:58
Copy link
Member

@tobru tobru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the concept, seems to make sense to me. Just some small hints, but nothing blocking.

@Kidswiss Kidswiss requested a review from tobru February 5, 2025 13:46
@Kidswiss
Copy link
Contributor Author

Kidswiss commented Feb 5, 2025

We should also add some more use-cases to this ADR. As from our first tech talk in the team:

We should enhance it with the ability to not only to keep separate functions and revisions for the tags, but also for a list of configurable branches.

So multiple branches and their functions could be rolled out at the same time on the same cluster. This will at least solve some of the bottlenecks we have with the lab.

Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kidswiss Kidswiss force-pushed the adr/functionrevisions branch from b351297 to 0d50c07 Compare February 26, 2025 08:16
@Kidswiss Kidswiss merged commit 5a47d94 into master Feb 26, 2025
1 check passed
@Kidswiss Kidswiss deleted the adr/functionrevisions branch February 26, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

decision A decision that changes the architecture

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants