Skip to content

Add high level description about RBAC in split architecture#138

Merged
Kidswiss merged 4 commits intomasterfrom
add/split_rbac
Mar 10, 2025
Merged

Add high level description about RBAC in split architecture#138
Kidswiss merged 4 commits intomasterfrom
add/split_rbac

Conversation

@Kidswiss
Copy link
Contributor

@Kidswiss Kidswiss commented Mar 4, 2025

Summary

Checklist

  • Try to isolate changes into separate PRs (to build a better changelog).
  • Categorize the PR by setting a good title and adding one of the labels:
    change, decision, requirement/quality, requirement/functional, dependency
    as they show up in the changelog
  • Link this PR to related issues if applicable.

@Kidswiss Kidswiss changed the title Add high level description about RBAC Add high level description about RBAC in split architecture Mar 4, 2025
@Kidswiss Kidswiss requested review from a team, TheBigLee, ThisIsntTheWay, wejdross and zugao and removed request for a team March 4, 2025 08:32
Co-authored-by: ThisIsntTheWay <ThisIsntTheWay@users.noreply.github.com>
Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some typos

Kidswiss and others added 2 commits March 4, 2025 14:47
Co-authored-by: Gabriel Saratura <58511627+zugao@users.noreply.github.com>
Co-authored-by: Gabriel Saratura <58511627+zugao@users.noreply.github.com>
Comment on lines +24 to +25
== Gotchas and Pitfalls
This chapter shows the pitfalls and gotchas that we need to keep in mind if we develop for a split architecture.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those lines provide no value to the reader, can we remove them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They make the rendered page a bit prettier. Without them, there will be two headings without any space between them.

@Kidswiss Kidswiss merged commit e74c4b4 into master Mar 10, 2025
1 check passed
@Kidswiss Kidswiss deleted the add/split_rbac branch March 10, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants