Add ADR for servala clusters and url naming scheme#140
Merged
Conversation
Kidswiss
approved these changes
Apr 11, 2025
docs/modules/ROOT/pages/adr/0031-naming-scheme-for-servala-cluster-names-and-urls.adoc
Outdated
Show resolved
Hide resolved
df7f5d4 to
4ddceaa
Compare
zugao
reviewed
Apr 11, 2025
docs/modules/ROOT/pages/adr/0031-naming-scheme-for-servala-cluster-names-and-urls.adoc
Outdated
Show resolved
Hide resolved
zugao
approved these changes
Apr 11, 2025
Contributor
zugao
left a comment
There was a problem hiding this comment.
Looks good, just one small thing
186a630 to
c878f73
Compare
Signed-off-by: Nicolas Bigler <nicolas.bigler@vshn.ch>
c878f73 to
1d6743e
Compare
tobru
requested changes
Apr 11, 2025
docs/modules/ROOT/pages/adr/0031-naming-scheme-for-servala-cluster-names-and-urls.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0031-naming-scheme-for-servala-cluster-names-and-urls.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0031-naming-scheme-for-servala-cluster-names-and-urls.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0031-naming-scheme-for-servala-cluster-names-and-urls.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0031-naming-scheme-for-servala-cluster-names-and-urls.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0031-naming-scheme-for-servala-cluster-names-and-urls.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0031-naming-scheme-for-servala-cluster-names-and-urls.adoc
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0031-naming-scheme-for-servala-cluster-names-and-urls.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0031-naming-scheme-for-servala-cluster-names-and-urls.adoc
Outdated
Show resolved
Hide resolved
|
|
||
| Putting all the information above together we propose the following naming scheme for servala cluster names: | ||
|
|
||
| `c-servala-[type]-[csp]-[region]-[stage][counter]` |
Member
There was a problem hiding this comment.
Please clearly describe each parameter. You can use https://docs.asciidoctor.org/asciidoc/latest/lists/description/ for that.
…ster-names-and-urls.adoc Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
…ster-names-and-urls.adoc Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
…ster-names-and-urls.adoc Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
…ster-names-and-urls.adoc Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
…ster-names-and-urls.adoc Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
…ster-names-and-urls.adoc Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
…ster-names-and-urls.adoc Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
Signed-off-by: Nicolas Bigler <nicolas.bigler@vshn.ch>
…ster-names-and-urls.adoc Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
…ster-names-and-urls.adoc Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
…ster-names-and-urls.adoc Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
…ster-names-and-urls.adoc Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
…ster-names-and-urls.adoc Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
tobru
approved these changes
Apr 11, 2025
docs/modules/ROOT/pages/adr/0031-naming-scheme-for-servala-cluster-names-and-urls.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0031-naming-scheme-for-servala-cluster-names-and-urls.adoc
Outdated
Show resolved
Hide resolved
…ster-names-and-urls.adoc Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
…ster-names-and-urls.adoc Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
simu
reviewed
Apr 11, 2025
docs/modules/ROOT/pages/adr/0031-naming-scheme-for-servala-cluster-names-and-urls.adoc
Outdated
Show resolved
Hide resolved
…ster-names-and-urls.adoc Co-authored-by: Simon Gerber <gesimu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
change,decision,requirement/quality,requirement/functional,dependencyas they show up in the changelog