Skip to content

Add ADR for servala clusters and url naming scheme#140

Merged
TheBigLee merged 18 commits intomasterfrom
servala_naming_scheme
Apr 16, 2025
Merged

Add ADR for servala clusters and url naming scheme#140
TheBigLee merged 18 commits intomasterfrom
servala_naming_scheme

Conversation

@TheBigLee
Copy link
Member

@TheBigLee TheBigLee commented Apr 11, 2025

Summary

Checklist

  • Try to isolate changes into separate PRs (to build a better changelog).
  • Categorize the PR by setting a good title and adding one of the labels:
    change, decision, requirement/quality, requirement/functional, dependency
    as they show up in the changelog
  • Link this PR to related issues if applicable.

@TheBigLee TheBigLee added the decision A decision that changes the architecture label Apr 11, 2025
@TheBigLee TheBigLee requested review from Kidswiss, tobru and zugao April 11, 2025 08:36
@TheBigLee TheBigLee force-pushed the servala_naming_scheme branch 2 times, most recently from df7f5d4 to 4ddceaa Compare April 11, 2025 09:25
Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small thing

@TheBigLee TheBigLee force-pushed the servala_naming_scheme branch 3 times, most recently from 186a630 to c878f73 Compare April 11, 2025 09:58
Signed-off-by: Nicolas Bigler <nicolas.bigler@vshn.ch>
@TheBigLee TheBigLee force-pushed the servala_naming_scheme branch from c878f73 to 1d6743e Compare April 11, 2025 09:59

Putting all the information above together we propose the following naming scheme for servala cluster names:

`c-servala-[type]-[csp]-[region]-[stage][counter]`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clearly describe each parameter. You can use https://docs.asciidoctor.org/asciidoc/latest/lists/description/ for that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

TheBigLee and others added 8 commits April 11, 2025 13:29
…ster-names-and-urls.adoc

Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
…ster-names-and-urls.adoc

Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
…ster-names-and-urls.adoc

Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
…ster-names-and-urls.adoc

Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
…ster-names-and-urls.adoc

Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
…ster-names-and-urls.adoc

Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
…ster-names-and-urls.adoc

Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
Signed-off-by: Nicolas Bigler <nicolas.bigler@vshn.ch>
@TheBigLee TheBigLee requested a review from tobru April 11, 2025 11:37
TheBigLee and others added 6 commits April 11, 2025 13:37
…ster-names-and-urls.adoc

Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
…ster-names-and-urls.adoc

Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
…ster-names-and-urls.adoc

Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
…ster-names-and-urls.adoc

Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
Signed-off-by: Nicolas Bigler <nicolas.bigler@vshn.ch>
…ster-names-and-urls.adoc

Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
Copy link
Member

@tobru tobru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things, then LGTM

TheBigLee and others added 2 commits April 11, 2025 13:45
…ster-names-and-urls.adoc

Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
…ster-names-and-urls.adoc

Co-authored-by: Tobias Brunner <tobias.brunner@vshn.ch>
…ster-names-and-urls.adoc

Co-authored-by: Simon Gerber <gesimu@gmail.com>
@TheBigLee TheBigLee merged commit b4e9f8d into master Apr 16, 2025
1 check passed
@TheBigLee TheBigLee deleted the servala_naming_scheme branch April 16, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

decision A decision that changes the architecture

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants