Conversation
Kidswiss
left a comment
There was a problem hiding this comment.
My first pass of reading this.
We should probably review and discuss this thing in stages. It's too large otherwise.
docs/modules/ROOT/pages/adr/0043-appcat-framework-production-architecture.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0043-appcat-framework-production-architecture.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0043-appcat-framework-production-architecture.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0043-appcat-framework-production-architecture.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0043-appcat-framework-production-architecture.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0043-appcat-framework-production-architecture.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0043-appcat-framework-production-architecture.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0043-appcat-framework-production-architecture.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0043-appcat-framework-production-architecture.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0043-appcat-framework-production-architecture.adoc
Outdated
Show resolved
Hide resolved
mikeshootzz
left a comment
There was a problem hiding this comment.
First of all, great job with the ADR! I agree with the comments from @Kidswiss and added some minor nitpicks.
docs/modules/ROOT/pages/adr/0043-appcat-framework-production-architecture.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0043-appcat-framework-production-architecture.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0043-appcat-framework-production-architecture.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0043-appcat-framework-production-architecture.adoc
Outdated
Show resolved
Hide resolved
tobru
left a comment
There was a problem hiding this comment.
This ADR is impossible to review in the current overly huge size. Please put some time into composing it into subpages which are graspable and reviewable.
It's clear that an AI assistant helped to write the ADR, which is great, but not really made for human reading IMHO, way too verbose.
Can you put some time into making it shorter again? Otherwise no one will be able to read it, ADRs are for human consumption and should be readable in a normal amount of time.
docs/modules/ROOT/pages/adr/0043-appcat-framework-production-architecture.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0043-appcat-framework-production-architecture.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0043-appcat-framework-production-architecture.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0043-appcat-framework-production-architecture.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0043-appcat-framework-production-architecture.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0043-appcat-framework-production-architecture.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0043-appcat-framework-production-architecture.adoc
Outdated
Show resolved
Hide resolved
d3dcc78 to
35acd7e
Compare
docs/modules/ROOT/pages/adr/0045-service-orchestration-crossplane-2-0.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0045-service-orchestration-crossplane-2-0.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0045-service-orchestration-crossplane-2-0.adoc
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0045-service-orchestration-crossplane-2-0.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0045-service-orchestration-crossplane-2-0.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0046-secret-management-framework-2-0.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0047-service-maintenance-and-upgrades-framework-2-0.adoc
Outdated
Show resolved
Hide resolved
mikeshootzz
left a comment
There was a problem hiding this comment.
I don't have anything to add apart from what was already said. Splitting into multiple ADRs is a lot more readable.
docs/modules/ROOT/pages/adr/0048-testing-strategy-framework-2-0.adoc
Outdated
Show resolved
Hide resolved
mikeshootzz
left a comment
There was a problem hiding this comment.
Briefly went over it again. We've got a good baseline here that we can amend in the future.
tobru
left a comment
There was a problem hiding this comment.
Some smaller things to improve, other than that, I think it's good to continue with starting the implementation.
docs/modules/ROOT/pages/adr/0045-service-orchestration-crossplane-2-0.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0045-service-orchestration-crossplane-2-0.adoc
Outdated
Show resolved
Hide resolved
docs/modules/ROOT/pages/adr/0047-service-maintenance-and-upgrades-framework-2-0.adoc
Outdated
Show resolved
Hide resolved
8ed5cdb to
12ca2a4
Compare
12ca2a4 to
d46311c
Compare
Summary
This PR adds ADRs 0044, 0045, 0046, 0047. It also describes how each problem is to be resolved from the point of view of Service Users, Service Maintainers, Service Operators and Framework Engineers.
Please run
make previewto read the rendered doc, check the index pageFramework 2.0from theFrameworksection on the left panel.Checklist
change,decision,requirement/quality,requirement/functional,dependencyas they show up in the changelog