Skip to content

Add ADR AppCat Framework 2.0#174

Merged
zugao merged 1 commit intomasterfrom
adr-framework-2
Jan 15, 2026
Merged

Add ADR AppCat Framework 2.0#174
zugao merged 1 commit intomasterfrom
adr-framework-2

Conversation

@zugao
Copy link
Contributor

@zugao zugao commented Dec 11, 2025

Summary

This PR adds ADRs 0044, 0045, 0046, 0047. It also describes how each problem is to be resolved from the point of view of Service Users, Service Maintainers, Service Operators and Framework Engineers.

Please run make preview to read the rendered doc, check the index page Framework 2.0 from the Framework section on the left panel.

Checklist

  • Try to isolate changes into separate PRs (to build a better changelog).
  • Categorize the PR by setting a good title and adding one of the labels:
    change, decision, requirement/quality, requirement/functional, dependency
    as they show up in the changelog
  • Link this PR to related issues if applicable.

@zugao zugao requested review from a team, Kidswiss, TheBigLee, mdnix and mikeshootzz and removed request for a team December 11, 2025 14:23
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My first pass of reading this.

We should probably review and discuss this thing in stages. It's too large otherwise.

Copy link
Contributor

@mikeshootzz mikeshootzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, great job with the ADR! I agree with the comments from @Kidswiss and added some minor nitpicks.

Copy link
Member

@tobru tobru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ADR is impossible to review in the current overly huge size. Please put some time into composing it into subpages which are graspable and reviewable.
It's clear that an AI assistant helped to write the ADR, which is great, but not really made for human reading IMHO, way too verbose.
Can you put some time into making it shorter again? Otherwise no one will be able to read it, ADRs are for human consumption and should be readable in a normal amount of time.

@zugao zugao force-pushed the adr-framework-2 branch 2 times, most recently from d3dcc78 to 35acd7e Compare December 23, 2025 13:34
Copy link
Contributor

@mikeshootzz mikeshootzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have anything to add apart from what was already said. Splitting into multiple ADRs is a lot more readable.

@zugao zugao requested review from mdnix and mikeshootzz January 6, 2026 13:17
Copy link
Contributor

@mikeshootzz mikeshootzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Briefly went over it again. We've got a good baseline here that we can amend in the future.

Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to start.

Copy link
Member

@tobru tobru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some smaller things to improve, other than that, I think it's good to continue with starting the implementation.

@zugao zugao requested a review from tobru January 13, 2026 10:15
@zugao zugao force-pushed the adr-framework-2 branch 2 times, most recently from 8ed5cdb to 12ca2a4 Compare January 15, 2026 10:39
@zugao zugao added the decision A decision that changes the architecture label Jan 15, 2026
@zugao zugao merged commit 5ef163d into master Jan 15, 2026
1 check passed
@zugao zugao deleted the adr-framework-2 branch January 15, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

decision A decision that changes the architecture

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants