Conversation
741edac to
ea178e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows registering and running WASM plugins from OCI registries like ghcr.io.
There is currently supoprt for
contextplugins.The plugin lifecycle is managed separately from the ManagedResource. For each plugin a runner pool is spawned. The repository is continously monitored for new versions and runners are replaced transparently if a new version exists.
The code on this branch can be tested by:
TODOs
The plugin should export a fucntion
espejote_plugin_versionandespejote_plugin_capabilities.OR maybe better: Configure using a "custom section" which would not violate spec by calling a function before
_initialize.Bonus TODOs
stealthrocket/wasi-gofor passing/etc/resolv.confand the TLS certificates.They are open for contributions Name resolution does not work without filesystem access dispatchrun/wasi-go#82
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog