Multiple signatures with one call (-S suffix) (and support for omitting filename in digest)#25
Open
urjaman wants to merge 4 commits intovstakhov:masterfrom
Open
Multiple signatures with one call (-S suffix) (and support for omitting filename in digest)#25urjaman wants to merge 4 commits intovstakhov:masterfrom
urjaman wants to merge 4 commits intovstakhov:masterfrom
Conversation
To allow making many different signatures with one context - and thus one password entry.
and for parsing omitted-name digests. This is an API change (but only to signing), so maybe we should instead have a different function for no-name signature write. Dunno.
vstakhov
approved these changes
Jun 25, 2024
Owner
vstakhov
left a comment
vstakhov
left a comment
There was a problem hiding this comment.
It looks good as is to me, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #23 and #24.
I'm not marking this as draft (because I'm not planning on re-doing this code - it's just for your inspiration ;) ), but consider it draft-quality, because i just hobbled it together (and did one fast test that it seems to build and do what I wanted.)