feat(user-widget): fix bugs in search by term; creates infinite scroll#201
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
| dataList: [], | ||
| totalDataList: 0, |
There was a problem hiding this comment.
For performance improvement, we removed these derived states to simply derive the query result (see below in this file).
|
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
Note: The list of the user active organizations is loaded in its entirety into memory because it is not possible to retrieve the filtered data from the masterdata in this case, since the organization and cost center name fields are in the
organizationsandcost_centersentities, and the search is performed on theb2b_usersentity, which contains only theorgIdandcostId. The organization and cost center names displayed in the table are from field resolvers that search in theorganizationsandcost_centersentities based on these IDs with the masterdatab2b_userssearch already performed. The benefit here is in loading the DOM, since too many elements will not be loaded initially.How to test it?
Workspace
Screenshots or example usage:
tiago--b2bstore005-myvtex-com.webm