chore: reduce check permission log level to warn#78
Conversation
enzomerca
requested review from
Copilot,
nicholas-maestrello and
pabloppupulin
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
There was a problem hiding this comment.
Pull request overview
This PR reduces the log level from error to warn for permission check failures in the withPermissions directive. This change acknowledges that permission check failures can occur for reasons unrelated to application errors, as these are already properly logged in the storefront-permissions app.
Key changes:
- Changed
logger.errortologger.warnin the permission check error handler - Updated CHANGELOG.md to document this change
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| node/resolvers/directives/withPermissions.ts | Changed log level from error to warn for permission check failures |
| CHANGELOG.md | Added entry documenting the log level reduction under "Changed" section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What problem is this solving?
The call to get the user permissions can fail for multiple reasons unrelated to app failure. In such cases, we already have proper logs in the storefront-permissions app.
Still, we want to maintain a log here in case we need to deep dive into an issue in the future.
Therefore, this PR reduces the log level to warn.