Skip to content

Fix Denmark's postal code field label - #656

Merged
jeffersontuc merged 2 commits into
mainfrom
fix/dnk-postalCode-label
Aug 27, 2025
Merged

Fix Denmark's postal code field label#656
jeffersontuc merged 2 commits into
mainfrom
fix/dnk-postalCode-label

Conversation

@jeffersontuc

@jeffersontuc jeffersontuc commented Aug 19, 2025

Copy link
Copy Markdown
Contributor

What is the purpose of this pull request?

ATTS

The "postal code" translation (Postnumre) for Denmark should be made trough the messages file, similar to es.json or pt-BR.json.

How should this be manually tested?

  • Access trackfieldeu cart
  • Change shipping-preview selected country to Dinamarca
  • Check if the postal code label shows a proper label

Screenshots or example usage

Before
image

After
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@jeffersontuc jeffersontuc self-assigned this Aug 19, 2025
@jeffersontuc
jeffersontuc requested a review from a team as a code owner August 19, 2025 18:24
@vtex-io-ci-cd

vtex-io-ci-cd Bot commented Aug 19, 2025

Copy link
Copy Markdown
Contributor

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@jeffersontuc
jeffersontuc force-pushed the fix/dnk-postalCode-label branch from 4386d35 to 79bcec7 Compare August 19, 2025 18:39
@jeffersontuc
jeffersontuc requested a review from a team August 19, 2025 18:39

@GeorgeLimaDev GeorgeLimaDev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. LGTM. 🚀

@GeorgeLimaDev

Copy link
Copy Markdown
Contributor

Please @jeffersontuc, be kind to consider #658 as well when moving on with this PR. Thank you.

@jeffersontuc
jeffersontuc force-pushed the fix/dnk-postalCode-label branch from 79bcec7 to 6861bb5 Compare August 27, 2025 19:13
@jeffersontuc
jeffersontuc merged commit 13146fc into main Aug 27, 2025
52 of 53 checks passed
@jeffersontuc
jeffersontuc deleted the fix/dnk-postalCode-label branch August 27, 2025 19:29
@jeffersontuc jeffersontuc mentioned this pull request Aug 27, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants