Skip to content

fix(textarea): remove max-width css property #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
viniciuslagedo wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(textarea): remove max-width css property #1981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
285d29e
fix(textarea): remove max width css prop
viniciuslagedo Sep 27, 2024
b01d4e9
test(textarea/stories): improve stacked textaread visualization
viniciuslagedo Sep 27, 2024
e33a91c
Merge remote-tracking branch 'origin' into fix/textarea-maxwidth
vaporwavie Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 10 additions & 55 deletions packages/shoreline/src/components/textarea/stories/examples.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import './style.css'
import React from 'react'

import { Textarea } from '../index'
import { Stack } from '../../stack'
import { Textarea } from '../index'

export default {
title: 'components/textarea',
Expand All @@ -15,84 +14,40 @@ export function NoResize() {
const [value, setValue] = React.useState('')

return (
<>
<Textarea
value={value}
onChange={setValue}
className="textarea-container"
resizable={false}
optional
/>
<Textarea
value={value}
onChange={setValue}
className="textarea-container"
resizable={false}
/>
<Textarea
value={value}
onChange={setValue}
className="textarea-container"
error
resizable={false}
/>
<Textarea
value={value}
onChange={setValue}
className="textarea-container"
disabled
resizable={false}
/>
<Stack>
<Textarea value={value} onChange={setValue} resizable={false} optional />
<Textarea value={value} onChange={setValue} resizable={false} />
<Textarea value={value} onChange={setValue} error resizable={false} />
<Textarea value={value} onChange={setValue} disabled resizable={false} />
<Textarea
value="The quick brown fox is tired right now"
className="textarea-container"
disabled
resizable={false}
/>
<Textarea
value={value}
onChange={setValue}
className="textarea-container"
maxLength={120}
resizable={false}
/>
</>
</Stack>
)
}

export function FormField() {
const [value, setValue] = React.useState('')

return (
<Textarea
error
className="textarea-container"
value={value}
onChange={setValue}
maxLength={120}
/>
)
return <Textarea error value={value} onChange={setValue} maxLength={120} />
}

export function LongText() {
const [value, setValue] = React.useState('')

return (
<Stack>
<Textarea
error
className="textarea-container"
value={value}
onChange={setValue}
maxLength={120}
/>
<Textarea error value={value} onChange={setValue} maxLength={120} />

<Textarea
error
className="textarea-container"
value={value}
onChange={setValue}
/>
<Textarea error value={value} onChange={setValue} />
</Stack>
)
}
53 changes: 10 additions & 43 deletions packages/shoreline/src/components/textarea/stories/show.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import './style.css'
import React from 'react'

import { Stack } from '../../stack'
import { Textarea } from '../index'

export default {
Expand All @@ -11,47 +11,14 @@ export function Show() {
const [value, setValue] = React.useState('')

return (
<>
<Textarea
value={value}
onChange={setValue}
className="textarea-container"
maxLength={120}
/>
<Textarea
value={value}
onChange={setValue}
className="textarea-container"
optional
/>
<Textarea
value={value}
onChange={setValue}
className="textarea-container"
/>
<Textarea
value={value}
onChange={setValue}
className="textarea-container"
error
/>
<Textarea
value={value}
onChange={setValue}
className="textarea-container"
disabled
/>
<Textarea
value="The quick brown fox is tired right now"
className="textarea-container"
disabled
/>
<Textarea
value={value}
onChange={setValue}
className="textarea-container"
maxLength={120}
/>
</>
<Stack>
<Textarea value={value} onChange={setValue} maxLength={120} />
<Textarea value={value} onChange={setValue} optional />
<Textarea value={value} onChange={setValue} />
<Textarea value={value} onChange={setValue} error />
<Textarea value={value} onChange={setValue} disabled />
<Textarea value="The quick brown fox is tired right now" disabled />
<Textarea value={value} onChange={setValue} maxLength={120} />
</Stack>
)
}
3 changes: 0 additions & 3 deletions packages/shoreline/src/components/textarea/stories/style.css
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/shoreline/src/themes/sunrise/components/textarea.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
[data-sl-textarea] {
width: 100%;
max-width: 20rem;
}

[data-sl-textarea-input] {
Expand Down