fix(filter-value): show children text content instead of value#1982
Open
viniciuslagedo wants to merge 2 commits intomainfrom
Open
fix(filter-value): show children text content instead of value#1982viniciuslagedo wants to merge 2 commits intomainfrom
viniciuslagedo wants to merge 2 commits intomainfrom
Conversation
Use the inner text from the selected item or from the first selected item instead of the value property. It makes more sense because the children prop is more related to visual purposal fix #1505
Contributor
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
rafarubim
reviewed
Sep 27, 2024
rafarubim
approved these changes
Sep 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partially resolves #1505
Now, the inner text from the children of the selected item is used on the selected value. Pay attention to the inner text expression here because it is not precisely the children property. So, no HTML tags will be rendered. I see that as a quick solution to not change all the state logic created.
Examples
Simple
For this example, when the item with value
rjis selected, the filter will show 'Cidade: Rio de Janeiro'Multiple
For this example, when the items with values
rjandmgare selected in that order, the filter will show 'Cidade: Rio de Janeiro, +1'