Skip to content

Fix GridCell area placement#2136

Open
vaporwavie wants to merge 1 commit intomainfrom
fix/gridcell-area-placement
Open

Fix GridCell area placement#2136
vaporwavie wants to merge 1 commit intomainfrom
fix/gridcell-area-placement

Conversation

@vaporwavie
Copy link
Copy Markdown
Contributor

Summary

Fix GridCell named-area placement so area is not overridden by implicit
auto placement values.

  • Stop emitting grid placement CSS variables when the related prop was not
    provided.
  • Remove the default --sl-grid-cell-* declarations from the grid cell theme
    CSS, avoiding cascade resets of grid-area.
  • Add a regression test covering named-area placement and explicit placement
    overrides.

Closes #1880.

Examples

<Grid
  columns="1fr 1fr"
  areas={`
    "header header"
    "main aside"
  `}
>
  <GridCell area="header">Header</GridCell>
  <GridCell area="main">Main</GridCell>
  <GridCell area="aside">Aside</GridCell>
</Grid>

@vaporwavie vaporwavie requested a review from a team as a code owner March 26, 2026 18:04
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
shoreline-docs Ignored Ignored Mar 26, 2026 6:04pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

GridCell not reflecting the area prop

1 participant