fix: resolve critical memory leak in VPivottableUi component (#270) #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove deep watch causing excessive property watchers - Replace computed PivotData with shallowRef - Add proper cleanup in lifecycle hooks - Achieve 94% memory reduction (881MB to 53MB)
Seungwoo321
added a commit
that referenced
this pull request
Aug 6, 2025
- Add v-model:pivotModel support to VPivottableUi component - Implement PivotModel interface and comprehensive type system - Fix filter changes to immediately reflect in PivotModel - Modify props to Partial<DefaultPropsType> for flexible pivotModel usage - Add PivotModel utility functions (compare, create, clone) - Add PivotModel history management composable (usePivotModelHistory) - Add PivotModel serialization/deserialization utilities - Fix ESLint duplicate key error by renaming imported aggregators - Merge memory leak fixes from PR #285 - Add comprehensive documentation in English and Korean 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #270 - Critical memory leak causing memory to increase from 50MB to 881MB after 1000 refreshes.
Problem
Solution
deep: truefrom watch, useimmediate: trueinsteadcomputedPivotData withshallowRefto reuse instancesonUnmountedlifecycle hookResults
Testing
Breaking Changes
None - This is a internal optimization that doesn't affect the API.
Related Issue
Closes #270