fix(space): review and enhance Space component#8505
Open
OPBR wants to merge 1 commit intovueComponent:feat/vaporfrom
Open
fix(space): review and enhance Space component#8505OPBR wants to merge 1 commit intovueComponent:feat/vaporfrom
OPBR wants to merge 1 commit intovueComponent:feat/vaporfrom
Conversation
68 tasks
- Add ConfigProvider size inheritance (sm/md/lg -> small/middle/large)
- Add RTL support via useConfigInject
- Add $attrs passthrough with inheritAttrs: false
- Add wrap mode with negative marginBottom
- Add empty children handling (return null if no valid children)
- Use filterEmpty for VNode filtering with Fragment support
- Add RTL support
- Add $attrs passthrough
- Add nested SpaceCompact detection via provide/inject
- Add default size ('md')
- Add align prop support
- Internal component for providing context to children
- Support nested SpaceCompact detection
- Provide isFirstItem/isLastItem context
- Add GLOBAL_SIZE_MAP for ConfigProvider size conversion
- Add spaceCompactContextKey for nested detection
- Enhance filterEmpty to handle Fragment children
- Export SizeType
- Add RTL styles for Space and SpaceCompact
- Update selectors for CompactItem wrapper
- Add align styles for SpaceCompact
- Add tests for RTL support
- Add tests for ConfigProvider size inheritance
- Add tests for align prop
- Add tests for Space.Compact static property
- Update snapshots
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Space.vue
SpaceCompact.vue
CompactItem.vue (new)
types.ts
style/index.css
Tests