fix(empty): restore static image API and locale fallback#8506
Merged
tangjinzhou merged 2 commits intovueComponent:feat/vaporfrom Apr 3, 2026
Merged
fix(empty): restore static image API and locale fallback#8506tangjinzhou merged 2 commits intovueComponent:feat/vaporfrom
tangjinzhou merged 2 commits intovueComponent:feat/vaporfrom
Conversation
Co-authored-by: OpenAI Codex <codex@openai.com>
68 tasks
…mple variant The default large SVG (184x152) should not get ant-empty-normal class which sets image height to 40px. Only the simple/small variant needs this class. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Review: fix(empty): restore static image API and locale fallbackPositive
Must Fix (pushed)
Consider
Pushed fix in commit 705a9ae. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of the component review effort for
feat/vapor, focused onEmpty.Main fixes:
Restored static image API compatibility
Empty.PRESENTED_IMAGE_DEFAULTEmpty.PRESENTED_IMAGE_SIMPLERestored built-in image behavior
imagenow supports built-in Empty image components, not only URL stringssimpleimage now correctly appliesant-empty-smallant-empty-normalRestored locale fallback behavior
ConfigProvider.locale.Empty.descriptionNo dataFixed image rendering priority
imageprop takes precedence overimageslot, matching expected component behaviorImproved verification coverage
Reviewed Areas
Validation
Passed:
npm --workspace @ant-design-vue/ui run test -- --run -u src/components/empty/__tests__/index.test.ts src/components/empty/__tests__/demo.test.ts