fix(steps): add missing props, fix a11y, replace hardcoded colors#8507
Open
xnkl-ck wants to merge 1 commit intovueComponent:feat/vaporfrom
Open
fix(steps): add missing props, fix a11y, replace hardcoded colors#8507xnkl-ck wants to merge 1 commit intovueComponent:feat/vaporfrom
xnkl-ck wants to merge 1 commit intovueComponent:feat/vaporfrom
Conversation
- types.ts: add progressDot, items, responsive, inline type, icon prop, ProgressDotRender type, StepItem interface, remove size default to allow ConfigProvider inheritance - Steps.vue: integrate useConfigInject for global size, useBreakpoint for responsive auto-vertical, support items prop via v-for, add inline/dot CSS classes, pass initial/progressDot/type via context - Step.vue: conditional role="button" only when clickable, support icon prop rendering, progressDot dot icon, initial offset in step numbering - style/index.css: replace 3x hardcoded #fff with CSS variables for dark theme support, add progressDot and inline type styles - tests: add Inline demo to demo.test.ts, add 7 new test cases for inline type, progressDot, items prop, initial offset, dot icon, conditional role, component names Co-Authored-By: Cursor <noreply@cursor.com> Made-with: Cursor
Author
|
Note: All 4 CI failures are pre-existing on the feat/vapor branch and unrelated to this PR:
Steps component tests all pass locally (53/53). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
progressDot,items,responsive,inlinetype,iconprop,ProgressDotRendertype,StepIteminterface; removesizedefault to allow ConfigProvider inheritanceuseConfigInjectfor global size,useBreakpointfor responsive auto-vertical; supportitemsprop viav-for; add inline/dot CSS classes; passinitial/progressDot/typevia contextrole="button"only when clickable; supporticonprop rendering; progressDot dot icon;initialoffset in step numbering#fffwith CSS variables for dark theme support; add progressDot and inline type stylesInlinedemo to demo.test.ts; add 7 new test cases (inline type, progressDot, items prop, initial offset, dot icon, conditional role, component names)Test plan