(PC) Feature/creation namecard #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vuefes-2024 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying vuefes-2024-designsystem with
|
| Latest commit: |
b4f7eba
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://82108fee.vuefes-2024-designsystem.pages.dev |
| Branch Preview URL: | https://feature-creation-namecard.vuefes-2024-designsystem.pages.dev |
jiyuujin
reviewed
Jul 21, 2024
| </script> | ||
|
|
||
| <template> | ||
| <!-- TODO 画像アップローダーのブラッシュアップ --> | ||
| <VFDragDropArea | ||
| <label |
jiyuujin
reviewed
Jul 21, 2024
| e.preventDefault() | ||
| navigateTo(`/namecard/${route.params.id}/edit/complete/`) | ||
| } | ||
| const receiptId = ref('') |
There was a problem hiding this comment.
NITS
昨年もそうだったかと記憶していますが、
編集時は receiptId 編集不可 (いわゆる disabled 状態) となるかもしれないです mm
|
memo
https://localhost:3000/namecard/null/?code=ba7e2a31-3f7c-4669-bd3d-a16274bf6513 ===== role が NULL のまま？だからですかね @vuejs-jp/web:dev: ERROR [nuxt] [request error] [unhandled] [500] Pattern matching error: no pattern matches value ""
@vuejs-jp/web:dev: at exhaustive (/Users/yuukit/projects/vuefes-2024/node_modules/ts-pattern/src/match.ts:124:11)
@vuejs-jp/web:dev: at Proxy.backgroundColor (/Users/yuukit/projects/vuefes-2024/packages/composable/lib/useUserRole.ts:4:244)
@vuejs-jp/web:dev: at _sfc_ssrRender (/Users/yuukit/projects/vuefes-2024/packages/ui/components/namecard/NamecardAvatar.vue:38:24)
@vuejs-jp/web:dev: at renderComponentSubTree (/Users/yuukit/projects/vuefes-2024/node_modules/@vue/server-renderer/dist/server-renderer.cjs.js:695:9)
@vuejs-jp/web:dev: at renderComponentVNode (/Users/yuukit/projects/vuefes-2024/node_modules/@vue/server-renderer/dist/server-renderer.cjs.js:641:12)
@vuejs-jp/web:dev: at Module.ssrRenderComponent (/Users/yuukit/projects/vuefes-2024/node_modules/@vue/server-renderer/dist/server-renderer.cjs.js:84:10)
@vuejs-jp/web:dev: at _sfc_ssrRender (/Users/yuukit/projects/vuefes-2024/packages/ui/components/namecard/Namecard23.vue:62:31)
@vuejs-jp/web:dev: at renderComponentSubTree (/Users/yuukit/projects/vuefes-2024/node_modules/@vue/server-renderer/dist/server-renderer.cjs.js:695:9)
@vuejs-jp/web:dev: at renderComponentVNode (/Users/yuukit/projects/vuefes-2024/node_modules/@vue/server-renderer/dist/server-renderer.cjs.js:641:12)
@vuejs-jp/web:dev: at Module.ssrRenderComponent (/Users/yuukit/projects/vuefes-2024/node_modules/@vue/server-renderer/dist/server-renderer.cjs.js:84:10)
|
jiyuujin
reviewed
Jul 21, 2024
| </div> | ||
| <CreationStatus :status-key="statusKey" size="small" class="creation-status" /> | ||
| <!-- TODO 24に置き換え&smallサイズ指定 --> | ||
| <VFNamecard23 :user="attendee" class="namecard-preview" /> |
There was a problem hiding this comment.
✍️
こちらをはじめ VFNamecard23 になっている箇所を VFNamecard24 へ書き換える to @totocalcio
There was a problem hiding this comment.
画面確認できるようになったら、書き換えて確認してみます。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ネームカード作成・シェアページの基本的な実装を行いました。
プレビュー環境での確認対応がまだできておらず、お手数ですがお手元で確認していただきたいです。
https://localhost:3000/namecard/
シェアカードページ
https://localhost:3000/namecard/be9367b9-4612-4b17-834b-f303cc96dc45/share/
未実装