-
Notifications
You must be signed in to change notification settings - Fork 1
Feat/add Namecard Component #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for vuefes-2024 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
あれ、packages/ui 配下では作成されなっかったんですね
OGP については Namecard24 と同じ場所に作成いただければ(ベース未作成ですが
https://github.com/vuejs-jp/vuefes-2024/blob/main/packages/ui/components/namecard/Namecard24.vue
slackで |
すみません、私の言葉足らずでした mm 基本 VFNamecard23 から VFNamecard24 に変更するだけではあるので
===== コンポーネント作成自体は apps/web で作成しようという意図はありませんので急ぎ |
@totocalcio cc: @KannoStanfoot 先ころ main ブランチにマージさせていただいたんで、apps/web への組込も対応いただけます mm https://github.com/vuejs-jp/vuefes-2024/pull/212/files#r1685705024 |
Deploying vuefes-2024-docs with
|
Latest commit: |
7447072
|
Status: | ✅ Deploy successful! |
Preview URL: | https://162e9ac7.vuefes-2024-docs.pages.dev |
Branch Preview URL: | https://feat-namecard.vuefes-2024-docs.pages.dev |
Deploying vuefes-2024-designsystem with
|
Latest commit: |
387f30e
|
Status: | ✅ Deploy successful! |
Preview URL: | https://ce89f28d.vuefes-2024-designsystem.pages.dev |
Branch Preview URL: | https://feat-namecard.vuefes-2024-designsystem.pages.dev |
<div class="avatar"> | ||
<span class="avatar-hook" aria-hidden="true" /> | ||
<div class="vuefes-logo-wrapper"> | ||
<img src="../../assets/namecard/vuefes_logo.svg" alt="vuefes logo" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NITS
SVG アイコンの箇所、表示されていなさそうな気がします
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Storybook上では問題ありませんでしたが、apps/web側に埋め込んだら表示されないことを確認しました。
調査・対応します。
issue
https://github.com/vuejs-jp/vuefes-2024-backside/issues/290
Design
https://www.figma.com/design/g0oSNTSYpa0byRxVv00Ugm/Vue-Fes-Japan-2024?node-id=4671-7411&t=09hXo4SApUtKEB6Y-4
Storybook
http://localhost:6006/?path=/story/namecard-namecard24--default&globals=viewport:responsive
Details of Changes
Screenshots