Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/runtime-vapor/__tests__/_utils.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { createVaporApp, defineVaporComponent } from '../src'
import { createVaporApp } from '../src'
import type { App } from '@vue/runtime-dom'
import type { VaporComponent, VaporComponentInstance } from '../src/component'
import type { RawProps } from '../src/componentProps'
Expand Down Expand Up @@ -36,7 +36,8 @@ export function makeRender<C = VaporComponent>(
})

function define(comp: C) {
const component = defineVaporComponent(comp as any)
const component = comp as any
component.__vapor = true
let instance: VaporComponentInstance | undefined
let app: App

Expand Down
21 changes: 21 additions & 0 deletions packages/runtime-vapor/__tests__/componentProps.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,27 @@ describe('component: props', () => {
expect(props).toBe(attrs)
})

test('functional defineVaporComponent without declaration', () => {
let props: any
let attrs: any

const { render } = define(
defineVaporComponent((_props: any, { attrs: _attrs }: any) => {
props = _props
attrs = _attrs
return []
}),
)

render({ foo: () => 1 })
expect(props).toEqual({})
expect(attrs).toEqual({ foo: 1 })

render({ bar: () => 2 })
expect(props).toEqual({})
expect(attrs).toEqual({ bar: 2 })
})

test('boolean casting', () => {
let props: any
const { render } = define({
Expand Down
17 changes: 15 additions & 2 deletions packages/runtime-vapor/src/apiDefineComponent.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,20 @@
import type { VaporComponent } from './component'
import type { ObjectVaporComponent, VaporComponent } from './component'
import { extend, isFunction } from '@vue/shared'

/*! #__NO_SIDE_EFFECTS__ */
export function defineVaporComponent(comp: VaporComponent): VaporComponent {
export function defineVaporComponent(
comp: VaporComponent,
extraOptions?: Omit<ObjectVaporComponent, 'setup'>,
): VaporComponent {
if (isFunction(comp)) {
// #8236: extend call and options.name access are considered side-effects
// by Rollup, so we have to wrap it in a pure-annotated IIFE.
return /*@__PURE__*/ (() =>
extend({ name: comp.name }, extraOptions, {
setup: comp,
__vapor: true,
}))()
}
// TODO type inference
comp.__vapor = true
return comp
Expand Down