Skip to content

feat(compiler-core): add openTagLoc and closeTagLoc to element ast node #12928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KazariEX wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(compiler-core): add openTagLoc and closeTagLoc to element ast node #12928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5f94ef9
feat(compiler-core): add `tagLoc` and `closeTagLoc` to element ast node
KazariEX Feb 22, 2025
e52d626
test: update snapshot
KazariEX Feb 22, 2025
1c89b42
Merge branch 'main' into feat/tag-loc
KazariEX Feb 22, 2025
308c7f0
refactor: opt-in
KazariEX Jun 18, 2025
b4566c2
Update parser.ts
KazariEX Jun 18, 2025
fb731b8
test: update snapshot
KazariEX Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/compiler-core/src/ast.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,8 @@ export interface BaseElementNode extends Node {
type: NodeTypes.ELEMENT
ns: Namespace
tag: string
openTagLoc?: SourceLocation
closeTagLoc?: SourceLocation
tagType: ElementTypes
props: Array<AttributeNode | DirectiveNode>
children: TemplateChildNode[]
Expand Down
5 changes: 5 additions & 0 deletions packages/compiler-core/src/options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,11 @@ export interface ParserOptions
* @default false
*/
prefixIdentifiers?: boolean
/**
* Whether to calculate the location of open tag and close tag of each node.
* @default false
*/
tagLocations?: boolean
/**
* A list of parser plugins to enable for `@babel/parser`, which is used to
* parse expressions in bindings and interpolations.
Expand Down
7 changes: 7 additions & 0 deletions packages/compiler-core/src/parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ export const defaultParserOptions: MergedParserOptions = {
onWarn: defaultOnWarn,
comments: __DEV__,
prefixIdentifiers: false,
tagLocations: false,
}

let currentOptions: MergedParserOptions = defaultParserOptions
Expand Down Expand Up @@ -146,6 +147,9 @@ const tokenizer = new Tokenizer(stack, {
loc: getLoc(start - 1, end),
codegenNode: undefined,
}
if (currentOptions.tagLocations) {
currentOpenTag.openTagLoc = getLoc(start, end)
}
},

onopentagend(end) {
Expand All @@ -165,6 +169,9 @@ const tokenizer = new Tokenizer(stack, {
}
for (let j = 0; j <= i; j++) {
const el = stack.shift()!
if (j === i && currentOptions.tagLocations) {
el.closeTagLoc = getLoc(start, end)
}
onCloseTag(el, end, j < i)
}
break
Expand Down