-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
fix(compiler-ssr): remove undefined/null class and style attrs #13745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: minor
Are you sure you want to change the base?
fix(compiler-ssr): remove undefined/null class and style attrs #13745
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
fix #13228 in SSR mode
Remove
undefined
/null
class
orstyle
attributes from SSR output to match the documented behavior https://vuejs.org/guide/essentials/template-syntax.html#attribute-bindingsNote: this is a breaking change due to the changes to
ssrRenderClass
/ssrRenderStyle
which are exposed to users from thevue/server-renderer
package. New functions can be created to avoid the breaking change but I feel it's worthwhile since the updated implementation matches that ofssrRenderAttrs