Skip to content

fix(compiler-ssr): remove undefined/null class and style attrs #13745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: minor
Choose a base branch
from

Conversation

alex-snezhko
Copy link
Contributor

fix #13228 in SSR mode

Remove undefined/null class or style attributes from SSR output to match the documented behavior https://vuejs.org/guide/essentials/template-syntax.html#attribute-bindings

Note: this is a breaking change due to the changes to ssrRenderClass/ssrRenderStyle which are exposed to users from the vue/server-renderer package. New functions can be created to avoid the breaking change but I feel it's worthwhile since the updated implementation matches that of ssrRenderAttrs

Copy link

coderabbitai bot commented Aug 10, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 84.1 kB 29.8 kB 26.3 kB
runtime-dom.global.prod.js 104 kB 39.1 kB 35.2 kB
vue.global.prod.js 162 kB 59.3 kB 52.8 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.1 kB 18.4 kB 16.9 kB
createApp 56 kB 21.6 kB 19.7 kB
createApp + vaporInteropPlugin 68.5 kB 25.8 kB 23.6 kB
createVaporApp 20.9 kB 8.26 kB 7.56 kB
createSSRApp 60.3 kB 23.3 kB 21.3 kB
defineCustomElement 61 kB 23.1 kB 21.1 kB
overall 70.5 kB 26.8 kB 24.4 kB

Copy link

pkg-pr-new bot commented Aug 10, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13745

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13745

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13745

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13745

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13745

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13745

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13745

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13745

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13745

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13745

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13745

vue

npm i https://pkg.pr.new/vue@13745

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13745

commit: 8607414

@edison1105 edison1105 added version: minor 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. scope: ssr ready to merge The PR is ready to be merged. breaking change labels Aug 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged. scope: ssr version: minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants