Skip to content

Conversation

9romise
Copy link

@9romise 9romise commented Sep 28, 2025

This PR is based on #13908, please merge that first.

It replaces the internal cleanup array in effectScope with an AbortSignal listener. This simplifies the cleanup logic.

I ran simple benchmarks on my machine and observed no noticeable performance difference compared to the current implementation.
image

Related: #13908 (comment).

Co-authored-by: Robin [email protected]

Copy link

coderabbitai bot commented Sep 28, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 84 kB 29.8 kB 26.3 kB
runtime-dom.global.prod.js 104 kB (+108 B) 39.2 kB (+37 B) 35.3 kB (+46 B)
vue.global.prod.js 162 kB (+108 B) 59.3 kB (+42 B) 52.9 kB (+36 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.3 kB (+96 B) 18.5 kB (+50 B) 16.9 kB (+41 B)
createApp 56.1 kB (+96 B) 21.6 kB (+43 B) 19.7 kB (+31 B)
createApp + vaporInteropPlugin 68.7 kB (+108 B) 25.9 kB (+55 B) 23.7 kB (+43 B)
createVaporApp 21.1 kB (+109 B) 8.39 kB (+53 B) 7.67 kB (+48 B)
createSSRApp 60.4 kB (+96 B) 23.4 kB (+39 B) 21.3 kB (+35 B)
defineCustomElement 61.1 kB (+96 B) 23.2 kB (+43 B) 21.2 kB (+46 B)
overall 70.6 kB (+96 B) 26.9 kB (+52 B) 24.5 kB (+39 B)

Copy link

pkg-pr-new bot commented Sep 29, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13938

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13938

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13938

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13938

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13938

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13938

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13938

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13938

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13938

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13938

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13938

vue

npm i https://pkg.pr.new/vue@13938

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13938

commit: 38f76c5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants