Walkthrough

Replaces the setTimeout fallback in whenTransitionEnds with a requestAnimationFrame-driven polling loop that checks elapsed time and triggers end() when the timeout threshold is reached.

Changes

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant App as Application
    participant whenTE as whenTransitionEnds
    participant Events as transition/animation events
    participant RAF as requestAnimationFrame loop

    App->>whenTE: whenTransitionEnds(el, timeout)
    whenTE->>Events: attach end event listeners
    Events-->>whenTE: end events fire (maybe)
    rect rgb(240,248,255)
      Note over whenTE,RAF: New flow — RAF polling fallback
      whenTE->>RAF: start fallbackTimeout (rAF loop)
      loop per frame
        RAF->>RAF: check elapsed >= timeout + 1 ?
        alt timeout reached
          RAF-->>whenTE: call end()
          RAF-->>whenTE: stop loop
        else continue
          RAF->>RAF: request next rAF
        end
      end
    end
    whenTE->>App: end() (from events or RAF)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Small, localized change in one file replacing a single timing mechanism.
• Pay attention to:
  • Correct termination of the RAF loop to avoid leaks.
  • Equivalence of timing (uses timeout + 1) vs prior setTimeout behavior.
  • Cases with multiple transitioned properties and event counting.

Possibly related issues

• Transition completes too early when using browser animation tab #14112 — same area (whenTransitionEnds timing fallback); this change appears to implement the RAF-based fallback discussed there.

Suggested labels

ready to merge, scope: transition, :hammer: p3-minor-bug

Poem

🐰 I hopped from timeout's ticking chime,
To frames that hum in steady time,
I watch each frame, no sudden end,
Frame by frame, the transitions mend,
A soft, precise and bouncy rhyme. 🥕✨

Pre-merge checks and finishing touches

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Size Report

Bundles

Usages