Skip to content

fix(hmr): handle cached text node update #14134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edison1105 merged 4 commits into from
Dec 18, 2025
+84 −6
Merged

fix(hmr): handle cached text node update #14134

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c70913b
fix(hmr): handle text node creation during HMR updates for cached nodes
edison1105 Nov 24, 2025
7e08418
fix: improve HMR updates for cached text nodes by replacing them
edison1105 Nov 25, 2025
6c11c4d
test: add test
edison1105 Nov 25, 2025
8bf4f30
Merge branch 'main' into edison/fix/14127
edison1105 Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/runtime-core/src/renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,8 +498,14 @@ function baseCreateRenderer(
anchor,
)
} else {
const el = (n2.el = n1.el!)
let el = (n2.el = n1.el!)
if (n2.children !== n1.children) {
// we don't inherit text node for cached text nodes in `traverseStaticChildren`
// but it maybe changed during HMR updates, so we need to handle this case by
// creating a new text node.
if (__DEV__ && isHmrUpdating && n2.patchFlag === PatchFlags.CACHED) {
el = hostCreateText(n2.children as string)
}
hostSetText(el, n2.children as string)
}
}
Expand Down
Loading