Skip to content

fix(templateRef): prevent duplicate onScopeDispose registrations for dynamic template refs #14161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edison1105 merged 4 commits into from
Dec 3, 2025
+107 −10
Merged

fix(templateRef): prevent duplicate onScopeDispose registrations for dynamic template refs #14161

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3932cb6
fix(runtime-vapor): conditionally enable `canSetSetupRef` check in de…
edison1105 Dec 3, 2025
bb0e242
fix(templateRef): prevent duplicate `onScopeDispose` registrations fo…
edison1105 Dec 3, 2025
3e68a1b
fix: ensure template ref cleanup passes null and deletes WeakMap entry
edison1105 Dec 3, 2025
4eaff71
test: add assertions for cleanup scope length in templateRef tests
edison1105 Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/runtime-vapor/src/apiTemplateRef.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import {
} from '@vue/runtime-dom'
import {
EMPTY_OBJ,
hasOwn,
NO,
isArray,
isFunction,
isString,
Expand Down Expand Up @@ -80,12 +80,12 @@ export function setRef(
const refs =
instance.refs === EMPTY_OBJ ? (instance.refs = {}) : instance.refs

const canSetSetupRef = createCanSetSetupRefChecker(setupState)
const canSetSetupRef = __DEV__ ? createCanSetSetupRefChecker(setupState) : NO
// dynamic ref changed. unset old ref
if (oldRef != null && oldRef !== ref) {
if (isString(oldRef)) {
refs[oldRef] = null
if (__DEV__ && hasOwn(setupState, oldRef)) {
if (__DEV__ && canSetSetupRef(oldRef)) {
setupState[oldRef] = null
}
} else if (isRef(oldRef)) {
Expand Down
Loading