Skip to content

Conversation

@edison1105
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 3, 2025 09:02
@coderabbitai
Copy link

coderabbitai bot commented Dec 3, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/fix/nonExistentProperty

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 85.2 kB 29.9 kB 26.4 kB
runtime-dom.global.prod.js 108 kB 40.5 kB 36.4 kB
vue.global.prod.js 166 kB 60.5 kB 53.8 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48 kB 18.8 kB 17.1 kB
createApp 57 kB 21.9 kB 20 kB
createApp + vaporInteropPlugin 95.4 kB 35.2 kB 31.7 kB
createVaporApp 40.6 kB 15.1 kB 13.7 kB
createSSRApp 61.4 kB 23.7 kB 21.6 kB
defineCustomElement 63.1 kB 23.8 kB 21.7 kB
overall 72.1 kB 27.3 kB 24.9 kB

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 3, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@14162

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@14162

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@14162

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@14162

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@14162

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@14162

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@14162

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@14162

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@14162

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@14162

@vue/shared

npm i https://pkg.pr.new/@vue/shared@14162

vue

npm i https://pkg.pr.new/vue@14162

@vue/compat

npm i https://pkg.pr.new/@vue/compat@14162

commit: 83eb7bd

@edison1105 edison1105 added version: minor scope: vapor related to vapor mode labels Dec 3, 2025
@edison1105 edison1105 merged commit 9bef3be into minor Dec 3, 2025
21 checks passed
@edison1105 edison1105 deleted the edison/fix/nonExistentProperty branch December 3, 2025 09:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a development-only warning to the runtime-vapor implementation that alerts developers when they access non-existent properties during component render. This matches similar functionality in the non-vapor runtime and helps catch common errors during development.

Key changes:

  • Added createDevSetupStateProxy function that wraps the setup state with a proxy in dev mode to detect and warn about undefined property access
  • Added test coverage to verify the warning is triggered correctly
  • Fixed an existing test that was accessing a non-existent property (style) which would now trigger the new warning

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/runtime-vapor/src/component.ts Implements dev proxy wrapper for setup state to warn on non-existent property access; adds imports for toRaw and hasOwn utilities
packages/runtime-vapor/tests/component.spec.ts Adds test case to verify warning is triggered when accessing non-existent properties during render
packages/runtime-vapor/tests/hmr.spec.ts Removes reference to non-existent style property from test template to avoid triggering the new warning

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: vapor related to vapor mode version: minor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants