Skip to content

fix(runtime-core): ensure correct anchor el for deeper unresolved async components #14182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
linzhe141 wants to merge 5 commits into
base: main
Choose a base branch
from
+111 −2
Open

fix(runtime-core): ensure correct anchor el for deeper unresolved async components #14182

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d62aff8
fix(runtime-core): ensure correct anchor el for deeper unresolved asy…
linzhe141 Dec 8, 2025
d368ab3
chore: add test unit
linzhe141 Dec 8, 2025
d186fd4
chore: tweaks
linzhe141 Dec 9, 2025
13995cb
fix(renderer): simplify async component placeholder resolution logic
edison1105 Dec 9, 2025
82a13bb
chore: simplify unit test
linzhe141 Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 95 additions & 0 deletions packages/runtime-core/__tests__/components/Suspense.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2360,6 +2360,101 @@ describe('Suspense', () => {
)
})

// #14173
test('nested async components with v-for + only Suspense and async component wrappers', async () => {
Copy link
Contributor

@Tofandel Tofandel Dec 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want an even smaller reproduction:

const items = ref([4, 5, 6]);
const App = {
  setup() {
    const loader = async () => defineComponent({
      props: {item: Number},
      setup(props) {
        return () => h('div', props.item)
      }
    });

    const LazyTest = defineAsyncComponent({
      loader: async () => defineComponent({
        setup(_, ctx) {
          const comp = defineAsyncComponent({
            loader: loader,
          })
          return () => h(comp, ctx.attrs)
        }
      }),
    })

    return () =>
      h(Suspense, null, {
        default: () =>
          h(
            Fragment,
            null,
            items.value.map(item =>
              h(LazyTest, {id: item, key: item}),
            ),
          ),
      })
  },
}

const root = nodeOps.createElement('div')
render(h(App), root)
await nextTick()
await Promise.all(deps)
await Promise.all(deps)

expect(serializeInner(root)).toBe(
  `<div>4</div><div>5</div><div>6</div>`,
)

items.value = [1,2,3]
await nextTick()
await Promise.all(deps)
await Promise.all(deps)
expect(serializeInner(root)).toBe(
  `<div>1</div><div>2</div><div>3</div>`,
)

Copy link
Contributor Author

@linzhe141 linzhe141 Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review. This unit test case was designed to reproduce nested async component wrappers and nested suspense wrappers, so it was a bit complex. I've now simplified the HTML to make it look less complicated.

const CompAsyncSetup = defineAsyncComponent({
props: ['item', 'id'],
render(ctx: any) {
return h('div', ctx.id + '--' + ctx.item.name)
},
})
const items = ref([
{ id: 1, name: '111' },
{ id: 2, name: '222' },
{ id: 3, name: '333' },
])
const Comp = {
props: ['id'],
setup(props: any) {
return () =>
h(Suspense, null, {
default: () =>
h(
Fragment,
null,
items.value.map(item =>
h(CompAsyncSetup, {
item,
key: item.id,
id: 'foo:' + props.id,
}),
),
),
})
},
}

const CompAsyncWrapper = defineAsyncComponent({
props: ['id'],
render(ctx: any) {
return h(Comp, { id: ctx.id })
},
})
const CompWrapper = defineComponent({
props: ['id'],
render(ctx: any) {
return h(CompAsyncWrapper, { id: ctx.id })
},
})
const list = ref([{ id: 1 }, { id: 2 }, { id: 3 }])

const App = {
setup() {
return () =>
h(Suspense, null, {
default: () =>
h(
Fragment,
null,
list.value.map(item =>
h(CompWrapper, { id: item.id, key: item.id }),
),
),
})
},
}

const root = nodeOps.createElement('div')
render(h(App), root)
await nextTick()
await Promise.all(deps)
await Promise.all(deps)

expect(serializeInner(root)).toBe(
`<div>foo:1--111</div><div>foo:1--222</div><div>foo:1--333</div><div>foo:2--111</div><div>foo:2--222</div><div>foo:2--333</div><div>foo:3--111</div><div>foo:3--222</div><div>foo:3--333</div>`,
)

list.value = [{ id: 4 }, { id: 5 }, { id: 6 }]
await nextTick()
await Promise.all(deps)
await Promise.all(deps)
expect(serializeInner(root)).toBe(
`<div>foo:4--111</div><div>foo:4--222</div><div>foo:4--333</div><div>foo:5--111</div><div>foo:5--222</div><div>foo:5--333</div><div>foo:6--111</div><div>foo:6--222</div><div>foo:6--333</div>`,
)

items.value = [
{ id: 4, name: '444' },
{ id: 5, name: '555' },
{ id: 6, name: '666' },
]
await nextTick()
await Promise.all(deps)
await Promise.all(deps)
expect(serializeInner(root)).toBe(
`<div>foo:4--444</div><div>foo:4--555</div><div>foo:4--666</div><div>foo:5--444</div><div>foo:5--555</div><div>foo:5--666</div><div>foo:6--444</div><div>foo:6--555</div><div>foo:6--666</div>`,
)
})

test('should call unmounted directive once when fallback is replaced by resolved async component', async () => {
const Comp = {
render() {
Expand Down
18 changes: 16 additions & 2 deletions packages/runtime-core/src/renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1995,8 +1995,8 @@ function baseCreateRenderer(
const anchorVNode = c2[nextIndex + 1] as VNode
const anchor =
nextIndex + 1 < l2
? // #13559, fallback to el placeholder for unresolved async component
anchorVNode.el || anchorVNode.placeholder
? // #13559, #14173 fallback to el placeholder for unresolved async component
anchorVNode.el || resolveAsyncComponentPlaceholder(anchorVNode)
: parentAnchor
if (newIndexToOldIndexMap[i] === 0) {
// mount new
Expand Down Expand Up @@ -2577,3 +2577,17 @@ export function invalidateMount(hooks: LifecycleHook): void {
hooks[i].flags! |= SchedulerJobFlags.DISPOSED
}
}

function resolveAsyncComponentPlaceholder(anchorVnode: VNode) {
if (anchorVnode.placeholder) {
return anchorVnode.placeholder
}

// anchor vnode maybe is a wrapper component has single unresolved async component
const instance = anchorVnode.component
if (instance) {
return resolveAsyncComponentPlaceholder(instance.subTree)
}

return null
}
Loading