Skip to content

fix(runtime-dom): handle activeElement check in Shadow DOM for v-model #14196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LordSalmon wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(runtime-dom): handle activeElement check in Shadow DOM for v-model #14196

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
287ae18
fix(v-model.trim): correct the activeElement discovery for shadow DOM
LordSalmon Dec 12, 2025
acebcdd
fix(v-model.trim): improve on previous approach
LordSalmon Dec 12, 2025
e700b25
Merge branch 'main' into lordsalmon/fix/v-model-trim-behaviour-in-sha…
edison1105 Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/runtime-dom/src/directives/vModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,12 @@ function castValue(value: string, trim?: boolean, number?: boolean | null) {
return value
}

function activeElement() {
return document.activeElement && document.activeElement.shadowRoot
? document.activeElement.shadowRoot.activeElement
: document.activeElement
}

// We are exporting the v-model runtime directly as vnode hooks so that it can
// be tree-shaken in case v-model is never used.
export const vModelText: ModelDirective<
Expand Down Expand Up @@ -102,7 +108,7 @@ export const vModelText: ModelDirective<
return
}

if (document.activeElement === el && el.type !== 'range') {
if (activeElement() === el && el.type !== 'range') {
// #8546
if (lazy && value === oldValue) {
return
Expand Down